netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* r8169: remove "PHY reset until link up" log spam
@ 2013-07-23  9:55 Peter Wu
  2013-07-23 12:22 ` Sergei Shtylyov
  2013-07-23 15:54 ` Stephen Hemminger
  0 siblings, 2 replies; 13+ messages in thread
From: Peter Wu @ 2013-07-23  9:55 UTC (permalink / raw)
  To: Francois Romieu; +Cc: David Miller, netdev, nic_swsd

This message was added in commit a7154cb8 (June 2004) and is printed
every ten seconds when no cable is connected.

Signed-off-by: Peter Wu <lekensteyn@gmail.com>
---
Using ethtool to silence *all* link warnings is still a manual
operation, in my opinion not acceptable so let's remove this message.

The r8169 constantly resets the device when no link is connected,
contrary the r8168 vendor driver which only resets the link when some
PCI config fields have been modified. As the current reset logic in r8168
seems to work for broken device (which I do not have have and therefore
cannot test), I did not attempt to "clean this up".
---
 drivers/net/ethernet/realtek/r8169.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
index 880015c..63f04af 100644
--- a/drivers/net/ethernet/realtek/r8169.c
+++ b/drivers/net/ethernet/realtek/r8169.c
@@ -3689,8 +3689,6 @@ static void rtl_phy_work(struct rtl8169_private *tp)
 	if (tp->link_ok(ioaddr))
 		return;
 
-	netif_warn(tp, link, tp->dev, "PHY reset until link up\n");
-
 	tp->phy_reset_enable(tp);
 
 out_mod_timer:
-- 
1.8.3.3

^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2013-07-23 21:51 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-23  9:55 r8169: remove "PHY reset until link up" log spam Peter Wu
2013-07-23 12:22 ` Sergei Shtylyov
2013-07-23 12:38   ` [PATCH v2] " Peter Wu
2013-07-23 20:23     ` Francois Romieu
2013-07-23 20:48       ` Peter Wu
2013-07-23 21:50         ` Francois Romieu
2013-07-23 15:54 ` Stephen Hemminger
2013-07-23 16:07   ` Peter Wu
2013-07-23 16:17     ` Stephen Hemminger
2013-07-23 21:18       ` Stephen Hemminger
2013-07-23 20:23     ` Francois Romieu
2013-07-23 20:59       ` Peter Wu
2013-07-23 21:51         ` Francois Romieu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).