From: "Nithin Nayak Sujir" <nsujir@broadcom.com>
To: "Gavin Shan" <shangw@linux.vnet.ibm.com>
Cc: netdev@vger.kernel.org, mchan@broadcom.com, davem@davemloft.net
Subject: Re: [PATCH 2/2] net/tg3: Fix warning from pci_disable_device()
Date: Wed, 24 Jul 2013 05:27:28 -0700 [thread overview]
Message-ID: <51EFC830.9080801@broadcom.com> (raw)
In-Reply-To: <1374657909-26929-2-git-send-email-shangw@linux.vnet.ibm.com>
On 7/24/2013 2:25 AM, Gavin Shan wrote:
> The patch fixes following warning. The PCI device might have been
> disabled somewhere else when we have EEH errors during early stage.
>
> Device tg3 disabling already-disabled device
> WARNING: at drivers/pci/pci.c:1403
> :
> NIP [c00000000044fd5c] .pci_disable_device+0xcc/0xe0
> LR [c00000000044fd58] .pci_disable_device+0xc8/0xe0
> Call Trace:
> [c000003f80bc7370] [c00000000044fd58] .pci_disable_device+0xc8/0xe0
> [c000003f80bc73f0] [d00000001cfe8fc0] .tg3_init_one+0x2f0/0x19f0 [tg3]
> [c000003f80bc74d0] [c0000000004534e8] .local_pci_probe+0x68/0xb0
> [c000003f80bc7560] [c0000000004537c8] .pci_device_probe+0x198/0x1a0
> [c000003f80bc7610] [c0000000004f9e98] .driver_probe_device+0xd8/0x450
> [c000003f80bc76a0] [c0000000004fa3bc] .__driver_attach+0x10c/0x110
> [c000003f80bc7730] [c0000000004f6e94] .bus_for_each_dev+0x94/0x100
> [c000003f80bc77d0] [c0000000004f9634] .driver_attach+0x34/0x50
> [c000003f80bc7850] [c0000000004f8f98] .bus_add_driver+0x288/0x380
> [c000003f80bc78f0] [c0000000004fae2c] .driver_register+0x9c/0x200
> [c000003f80bc7980] [c000000000453214] .__pci_register_driver+0x64/0x90
> [c000003f80bc7a10] [d00000001cff7a60] .tg3_driver_init+0x2c/0x40 [tg3]
> [c000003f80bc7a80] [c00000000000b424] .do_one_initcall+0x144/0x1f0
> [c000003f80bc7b70] [c0000000001244a0] .load_module+0x1f30/0x2700
> [c000003f80bc7d40] [c000000000124e80] .SyS_finit_module+0xc0/0x110
> [c000003f80bc7e30] [c000000000009dd4] syscall_exit+0x0/0x98
>
> Reported-by: Wei Yang <weiyang@linux.vnet.ibm.com>
> Signed-off-by: Gavin Shan <shangw@linux.vnet.ibm.com>
> ---
> drivers/net/ethernet/broadcom/tg3.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
> index aee1b9a..ddebc7a 100644
> --- a/drivers/net/ethernet/broadcom/tg3.c
> +++ b/drivers/net/ethernet/broadcom/tg3.c
> @@ -17625,7 +17625,8 @@ err_out_free_res:
> pci_release_regions(pdev);
>
> err_out_disable_pdev:
> - pci_disable_device(pdev);
> + if (pci_is_enabled(pdev))
> + pci_disable_device(pdev);
> pci_set_drvdata(pdev, NULL);
> return err;
> }
>
Acked-by: Nithin Nayak Sujir <nsujir@broadcom.com>
next prev parent reply other threads:[~2013-07-24 12:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-24 9:25 [PATCH 1/2] net/tg3: Fix kernel crash Gavin Shan
2013-07-24 9:25 ` [PATCH 2/2] net/tg3: Fix warning from pci_disable_device() Gavin Shan
2013-07-24 12:27 ` Nithin Nayak Sujir [this message]
2013-07-26 21:28 ` David Miller
2013-07-24 12:27 ` [PATCH 1/2] net/tg3: Fix kernel crash Nithin Nayak Sujir
2013-07-26 21:28 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51EFC830.9080801@broadcom.com \
--to=nsujir@broadcom.com \
--cc=davem@davemloft.net \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=shangw@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).