From: Alexander Duyck <alexander.h.duyck@intel.com>
To: John Fastabend <john.fastabend@gmail.com>
Cc: Ben Hutchings <bhutchings@solarflare.com>,
Jiri Pirko <jiri@resnulli.us>,
netdev@vger.kernel.org, davem@davemloft.net,
stephen@networkplumber.org, Narendra_K@Dell.com,
john.r.fastabend@intel.com, or.gerlitz@gmail.com,
jeffrey.t.kirsher@intel.com, jesse.brandeburg@intel.com,
bruce.w.allan@intel.com, carolyn.wyborny@intel.com,
donald.c.skidmore@intel.com, gregory.v.rose@intel.com,
peter.p.waskiewicz.jr@intel.com, john.ronciak@intel.com,
tushar.n.dave@intel.com, matthew.vick@intel.com,
mitch.a.williams@intel.com, vyasevic@redhat.com,
amwang@redhat.com, johannes@sipsolutions.net
Subject: Re: [patch net-next v4 4/4] igb/igbvf: implement ndo_get_phys_port_id
Date: Thu, 25 Jul 2013 15:27:50 -0700 [thread overview]
Message-ID: <51F1A666.8050001@intel.com> (raw)
In-Reply-To: <51F18366.2040306@gmail.com>
On 07/25/2013 12:58 PM, John Fastabend wrote:
> On 07/25/2013 12:15 PM, Ben Hutchings wrote:
>> On Thu, 2013-07-25 at 12:03 -0700, Alexander Duyck wrote:
>>> On 07/25/2013 11:51 AM, Ben Hutchings wrote:
>>>> On Thu, 2013-07-25 at 11:00 -0700, Alexander Duyck wrote:
>>>>> On 07/25/2013 09:44 AM, Ben Hutchings wrote:
>>>>>> On Thu, 2013-07-25 at 09:17 -0700, Alexander Duyck wrote:
>>>>>>> On 07/25/2013 06:03 AM, Jiri Pirko wrote:
>>>>>>>> @@ -1982,6 +2001,21 @@ static s32 igb_init_i2c(struct
>>>>>>>> igb_adapter *adapter)
>>>>>>>> return status;
>>>>>>>> }
>>>>>>>>
>>>>>>>> +static void igb_compute_phys_port_id(struct igb_adapter *adapter)
>>>>>>>> +{
>>>>>>>> + adapter->phys_port_id = *((u32 *) adapter->netdev->dev_addr);
>>>>>>>> + adapter->phys_port_id ^= *((u32 *)
>>>>>>>> adapter->netdev->dev_addr + 4);
>>>>>>>> + adapter->phys_port_id ^= (long) adapter;
>>>>>>>> + adapter->phys_port_id ^= (long) adapter->hw.hw_addr;
>>>>>>>> + adapter->phys_port_id ^= (long) adapter->hw.flash_address;
>>>>>>>> + adapter->phys_port_id ^= (u32) adapter->hw.io_base;
>>>>>>>> + adapter->phys_port_id ^= adapter->hw.device_id;
>>>>>>>> + adapter->phys_port_id ^= adapter->hw.subsystem_vendor_id;
>>>>>>>> + adapter->phys_port_id ^= adapter->hw.subsystem_device_id;
>>>>>>>> + adapter->phys_port_id ^= adapter->hw.vendor_id;
>>>>>>>> + adapter->phys_port_id ^= adapter->hw.revision_id;
>>>>>> I didn't look at Jiri's patch initially, but... what's wrong with
>>>>>> using
>>>>>> the MAC address from NVRAM (should already be in netdev->perm_addr)?
>>>>>> That's what I'm expecting to do for the SFC9000 family in sfc.
>>>>>>
>>>>>>>> +}
>>>>>>>> +
>>>>>>>> /**
>>>>>>>> * igb_probe - Device Initialization Routine
>>>>>>>> * @pdev: PCI device information struct
>>>>>>> I really think this bit here should be standardized and made
>>>>>>> available
>>>>>>> to all drivers.
>>>>>> [...]
>>>>>>
>>>>>> I think it's a bad example and should not be used in any drivers!
>>>>>>
>>>>>> Ben.
>>>>>>
>>>>> I agree. That is why the second paragraph started listing what was
>>>>> wrong with this implementation. What I said was meant in the more
>>>>> general sense that whatever solution should be used should be the
>>>>> same
>>>>> across multiple drivers, not up to each driver to compute.
>>>> I would love to know how you think this can be done generically.
>>>> If it
>>>> can then we don't need the driver operation at all.
>>>>
>>>> Ben.
>>>>
>>>
>>> Well like you mentioned, you could just pull this out out of
>>> netdev->perm_addr. You don't need to have anything driver specific as
>>> long as that is the field you are using generic netdev or pci_dev
>>> attributes to do the identification.
>>
>> For a PF driver that never shares the port with another PF, yes. There
>> are a handful of those drivers so it might be worth sharing an
>> implementation that uses perm_addr, but it's so trivial...
>>
>>> All you need is something that
>>> uniquely identifies the device in the system correct?
>>
>> The spec is that it is universally unique. I don't know who's going to
>> need that property but I think it's achievable since each physical port
>> normally has at least one globally unique MAC address assigned at
>> manufacturing time.
>>
>>> For that matter
>>> it seems like you could probably just pull the domain, bus, device, and
>>> function number out of the PCI device and that would probably work as
>>> well as long as you cannot somehow have PFs running inside of guests.
>>
>> Some NICs have multiple PFs for the same port, and those could be
>> assigned to guest VMs.
>>
>> All VF drivers would need some way to get the port ID, and that can't be
>> done generically from inside a guest VM.
>>
>> Ben.
>>
>
> I doubt you'll be able to think up a way to do this generically as Ben
> points out. But also no reason for the complicated hash just use the
> perm address of the PF and if you have multiple PFs elect one of the
> n perm address to be the stand-in for the unique one.
>
> .John
>
I think there may have been some miscommunication. I wasn't talking
about the VF drivers having a generic means of getting the ID. I would
just want all of the drivers to be using a similar approach for
generating the port ID so that we reduce the risk of any kind of port ID
collision. We need to make sure we are all stuffing the 6 bytes of
perm_addr into the 4 byte port ID using the same approach.
Thanks,
Alex
next prev parent reply other threads:[~2013-07-25 22:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-25 13:03 [patch net-next v4 0/4] export device physical port id to userspace Jiri Pirko
2013-07-25 13:03 ` [patch net-next v4 1/4] net: add ndo to get id of physical port of the device Jiri Pirko
2013-07-25 13:03 ` [patch net-next v4 2/4] rtnl: export physical port id via RT netlink Jiri Pirko
2013-07-25 13:03 ` [patch net-next v4 3/4] net: export physical port id via sysfs Jiri Pirko
2013-07-25 13:03 ` [patch net-next v4 4/4] igb/igbvf: implement ndo_get_phys_port_id Jiri Pirko
2013-07-25 16:17 ` Alexander Duyck
2013-07-25 16:44 ` Ben Hutchings
2013-07-25 18:00 ` Alexander Duyck
2013-07-25 18:51 ` Ben Hutchings
2013-07-25 19:03 ` Alexander Duyck
2013-07-25 19:15 ` Ben Hutchings
2013-07-25 19:58 ` John Fastabend
2013-07-25 22:27 ` Alexander Duyck [this message]
2013-07-25 22:44 ` Ben Hutchings
2013-07-25 22:56 ` Alexander Duyck
2013-07-25 19:23 ` Rose, Gregory V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F1A666.8050001@intel.com \
--to=alexander.h.duyck@intel.com \
--cc=Narendra_K@Dell.com \
--cc=amwang@redhat.com \
--cc=bhutchings@solarflare.com \
--cc=bruce.w.allan@intel.com \
--cc=carolyn.wyborny@intel.com \
--cc=davem@davemloft.net \
--cc=donald.c.skidmore@intel.com \
--cc=gregory.v.rose@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=jiri@resnulli.us \
--cc=johannes@sipsolutions.net \
--cc=john.fastabend@gmail.com \
--cc=john.r.fastabend@intel.com \
--cc=john.ronciak@intel.com \
--cc=matthew.vick@intel.com \
--cc=mitch.a.williams@intel.com \
--cc=netdev@vger.kernel.org \
--cc=or.gerlitz@gmail.com \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=stephen@networkplumber.org \
--cc=tushar.n.dave@intel.com \
--cc=vyasevic@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).