From: Amir Vadai <amirv@mellanox.com>
To: Jingoo Han <jg1.han@samsung.com>
Cc: "'David S. Miller'" <davem@davemloft.net>,
<netdev@vger.kernel.org>,
'Yevgeny Petrilin' <yevgenyp@mellanox.com>,
'Eugenia Emantayev' <eugenia@mellanox.com>
Subject: Re: [PATCH 4/4] net: mlx4: Staticize local functions
Date: Mon, 5 Aug 2013 14:13:10 +0300 [thread overview]
Message-ID: <51FF88C6.7060803@mellanox.com> (raw)
In-Reply-To: <002401ce91ba$d8025860$88070920$@samsung.com>
On 05/08/2013 12:04, Jingoo Han wrote:
> These local functions are used only in this file.
> Fix the following sparse warnings:
>
> drivers/net/ethernet/mellanox/mlx4/cmd.c:803:5: warning: symbol 'MLX4_CMD_UPDATE_QP_wrapper' was not declared. Should it be static?
> drivers/net/ethernet/mellanox/mlx4/cmd.c:812:5: warning: symbol 'MLX4_CMD_GET_OP_REQ_wrapper' was not declared. Should it be static?
> drivers/net/ethernet/mellanox/mlx4/cmd.c:1547:5: warning: symbol 'mlx4_master_immediate_activate_vlan_qos' was not declared. Should
> it be static?
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/net/ethernet/mellanox/mlx4/cmd.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx4/cmd.c b/drivers/net/ethernet/mellanox/mlx4/cmd.c
> index 141322c..ea20182 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/cmd.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/cmd.c
> @@ -800,7 +800,7 @@ static int mlx4_MAD_IFC_wrapper(struct mlx4_dev *dev, int slave,
> vhcr->op, MLX4_CMD_TIME_CLASS_C, MLX4_CMD_NATIVE);
> }
>
> -int MLX4_CMD_UPDATE_QP_wrapper(struct mlx4_dev *dev, int slave,
> +static int MLX4_CMD_UPDATE_QP_wrapper(struct mlx4_dev *dev, int slave,
> struct mlx4_vhcr *vhcr,
> struct mlx4_cmd_mailbox *inbox,
> struct mlx4_cmd_mailbox *outbox,
> @@ -809,7 +809,7 @@ int MLX4_CMD_UPDATE_QP_wrapper(struct mlx4_dev *dev, int slave,
> return -EPERM;
> }
>
> -int MLX4_CMD_GET_OP_REQ_wrapper(struct mlx4_dev *dev, int slave,
> +static int MLX4_CMD_GET_OP_REQ_wrapper(struct mlx4_dev *dev, int slave,
> struct mlx4_vhcr *vhcr,
> struct mlx4_cmd_mailbox *inbox,
> struct mlx4_cmd_mailbox *outbox,
> @@ -1544,7 +1544,7 @@ static int calculate_transition(u16 oper_vlan, u16 admin_vlan)
> return (2 * (oper_vlan == MLX4_VGT) + (admin_vlan == MLX4_VGT));
> }
>
> -int mlx4_master_immediate_activate_vlan_qos(struct mlx4_priv *priv,
> +static int mlx4_master_immediate_activate_vlan_qos(struct mlx4_priv *priv,
> int slave, int port)
> {
> struct mlx4_vport_oper_state *vp_oper;
>
Acked-By: Amir Vadai <amirv@mellanox.com>
next prev parent reply other threads:[~2013-08-05 11:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-05 9:04 [PATCH 4/4] net: mlx4: Staticize local functions Jingoo Han
2013-08-05 11:13 ` Amir Vadai [this message]
2013-08-05 18:10 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51FF88C6.7060803@mellanox.com \
--to=amirv@mellanox.com \
--cc=davem@davemloft.net \
--cc=eugenia@mellanox.com \
--cc=jg1.han@samsung.com \
--cc=netdev@vger.kernel.org \
--cc=yevgenyp@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).