netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Keller, Jacob E" <jacob.e.keller@intel.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	Jakub Kicinski <kubakici@wp.pl>, Jiri Pirko <jiri@resnulli.us>
Subject: RE: [PATCH net-next RFC] devlink: add commands to query flash and reload support
Date: Wed, 14 Jul 2021 20:54:56 +0000	[thread overview]
Message-ID: <51a6e7a33c7d40889c80bf37159f210e@intel.com> (raw)
In-Reply-To: <YO9ITZknrXte6jpB@lunn.ch>



> -----Original Message-----
> From: Andrew Lunn <andrew@lunn.ch>
> Sent: Wednesday, July 14, 2021 1:26 PM
> To: Keller, Jacob E <jacob.e.keller@intel.com>
> Cc: netdev@vger.kernel.org; Jakub Kicinski <kubakici@wp.pl>; Jiri Pirko
> <jiri@resnulli.us>
> Subject: Re: [PATCH net-next RFC] devlink: add commands to query flash and
> reload support
> 
> > I'm not sure if this is the best direction to go for implementing this.
> 
> Hi Jacob
> 
> Maybe add a --dry-run option? That would allow the driver to also read
> the firmware file, make sure it can parse it, it fits the actual
> hardware, and the CRC is O.K, etc.
> 
> We just need to make sure that if it fails with -EOPNOTSUPP, is it
> clear if --dry-run itself is not supported, or the operation is not
> supported. extack should help with that.
> 
> 	   Andrew

That approach could be useful. It doesn't give an easy way to dump all of the supported flags, but that's not super critical. I think a dry-run makes a lot of sense for flash update.

I can go that approach for these two and see how it turns out.

Thanks,
Jake

      reply	other threads:[~2021-07-14 20:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-14 19:39 Jacob Keller
2021-07-14 20:25 ` Andrew Lunn
2021-07-14 20:54   ` Keller, Jacob E [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51a6e7a33c7d40889c80bf37159f210e@intel.com \
    --to=jacob.e.keller@intel.com \
    --cc=andrew@lunn.ch \
    --cc=jiri@resnulli.us \
    --cc=kubakici@wp.pl \
    --cc=netdev@vger.kernel.org \
    --subject='RE: [PATCH net-next RFC] devlink: add commands to query flash and reload support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).