From: Eliezer Tamir <eliezer.tamir@linux.intel.com>
To: Shawn Bohrer <sbohrer@rgmadvisors.com>
Cc: Amir Vadai <amirv@mellanox.com>, netdev@vger.kernel.org
Subject: Re: low latency/busy poll feedback and bugs
Date: Tue, 06 Aug 2013 10:41:48 +0300 [thread overview]
Message-ID: <5200A8BC.4010402@linux.intel.com> (raw)
In-Reply-To: <20130805212257.GB6904@sbohrermbp13-local.rgmadvisors.com>
On 06/08/2013 00:22, Shawn Bohrer wrote:
> 1) I'm testing with a Mellanox ConnectX-3 card.
There's your problem ;)
> 2) Why is LowLatencyRxPackets reported as a TcpExt stat? Perhaps I've
> been confused and misguided but I've always assumed those are
> statistics related to TCP and this feature is protocol neutral. I'm
> not entirely sure where it should be moved to perhaps IpExt?
Actually, after all of the rewrite this has gone through,
it's now at the Ethernet level, not even IP specific.
So where should it go?
Should we also rename this to BusyPollRxPackets?
> 3) I don't know if this was intentional, an oversight, or simply a
> missing feature but UDP multicast currently is not supported. In
> order to add support I believe you would need to call
> sk_mark_napi_id() in __udp4_lib_mcast_deliver(). Assuming there isn't
> some intentional reason this wasn't done I'd be happy to test this and
> send a patch.
This is still WIP, so our goal was to make it easy to extend for new
cases and protocols.
For multicast, it is possible that incoming packets to come from more
than one port (and therefore more than one queue).
I'm not sure how we could handle that, but what we have today won't do
well for that use-case.
What do you use for testing?
-Eliezer
next prev parent reply other threads:[~2013-08-06 7:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-05 21:22 low latency/busy poll feedback and bugs Shawn Bohrer
2013-08-05 22:16 ` [PATCH net-next] net: Add low-latency/polling support for UDP multicast Shawn Bohrer
2013-08-06 7:13 ` Eliezer Tamir
2013-08-06 19:51 ` [PATCH v2 " Shawn Bohrer
2013-08-07 20:22 ` Eric Dumazet
2013-08-08 8:46 ` Eliezer Tamir
2013-08-08 23:55 ` Eric Dumazet
2013-08-11 7:59 ` Eliezer Tamir
2013-08-06 7:41 ` Eliezer Tamir [this message]
2013-08-06 18:08 ` low latency/busy poll feedback and bugs Shawn Bohrer
2013-08-06 18:25 ` Eliezer Tamir
2013-08-07 20:05 ` Ben Hutchings
2013-08-07 20:23 ` Eric Dumazet
2013-08-07 23:41 ` David Miller
2013-08-06 20:39 ` Or Gerlitz
2013-08-06 21:02 ` Eric Dumazet
2013-08-06 12:15 ` Amir Vadai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5200A8BC.4010402@linux.intel.com \
--to=eliezer.tamir@linux.intel.com \
--cc=amirv@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=sbohrer@rgmadvisors.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).