From: Or Gerlitz <ogerlitz@mellanox.com>
To: Tom Herbert <therbert@google.com>
Cc: Jerry Chu <hkchu@google.com>, Eric Dumazet <edumazet@google.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Linux Netdev List <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>,
Yan Burman <yanb@mellanox.com>,
Shlomo Pongratz <shlomop@mellanox.com>
Subject: Re: [PATCH net-next V3 1/3] net: Add GRO support for UDP encapsulating protocols
Date: Thu, 9 Jan 2014 09:14:31 +0200 [thread overview]
Message-ID: <52CE4C57.1020307@mellanox.com> (raw)
In-Reply-To: <CA+mtBx9OaN1i1qX3cf8jAqrCmYB06K1f-Fxh+GorWxMcNVj4JA@mail.gmail.com>
On 09/01/2014 09:09, Tom Herbert wrote:
>> + for (p = *head; p; p = p->next) {
>> >+ if (!NAPI_GRO_CB(p)->same_flow)
>> >+ continue;
>> >+
>> >+ uh2 = (struct udphdr *)(p->data + off);
>> >+ if ((*(u32 *)&uh->source != *(u32 *)&uh2->source)) {
>> >+ NAPI_GRO_CB(p)->same_flow = 0;
>> >+ continue;
>> >+ }
>> >+ goto found;
> I don't believe this is correct. If you exit on the first match, skb's
> that follow in the list can still be marked as same_flow. You need to
> walk the whole list I believe (just get rid of the goto).
>
Good catch, will fix.
Looking on the ipv4 and gre gro_receive callbacks they indeed go over
all the list where the tcp gro_receive code does allow itself do goto
found, probably b/c they are last in the chain?
next prev parent reply other threads:[~2014-01-09 7:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-08 20:34 [PATCH net-next V3 0/3] net: Add GRO support for UDP encapsulating protocols Or Gerlitz
2014-01-08 20:34 ` [PATCH net-next V3 1/3] " Or Gerlitz
2014-01-08 20:39 ` Or Gerlitz
2014-01-08 21:58 ` Tom Herbert
2014-01-09 6:25 ` Or Gerlitz
2014-01-09 7:09 ` Tom Herbert
2014-01-09 7:14 ` Or Gerlitz [this message]
2014-01-08 20:34 ` [PATCH net-next V3 2/3] net: Export gro_find_by_type helpers Or Gerlitz
2014-01-08 20:34 ` [PATCH net-next V3 3/3] net: Add GRO support for vxlan traffic Or Gerlitz
2014-01-08 22:09 ` Eric Dumazet
2014-01-09 6:28 ` Or Gerlitz
2014-01-08 22:11 ` Eric Dumazet
2014-01-09 6:32 ` Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52CE4C57.1020307@mellanox.com \
--to=ogerlitz@mellanox.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=hkchu@google.com \
--cc=netdev@vger.kernel.org \
--cc=shlomop@mellanox.com \
--cc=therbert@google.com \
--cc=yanb@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).