From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Dominic Curran <dominic.curran@citrix.com>, netdev@vger.kernel.org
Cc: Jason Wang <jasowang@redhat.com>, Maxim Krasnyansky <maxk@qualcomm.com>
Subject: Re: [RFC PATCH] tuntap: Fix for a race in accessing numqueue
Date: Sat, 18 Jan 2014 21:43:17 +0400 [thread overview]
Message-ID: <52DABD35.3030408@cogentembedded.com> (raw)
In-Reply-To: <1390004815-7052-1-git-send-email-dominic.curran@citrix.com>
Hello.
On 18-01-2014 4:26, Dominic Curran wrote:
> A patch for fixing a race between queue selection and changing queues
> was introduced in commit 92bb73ea2c434618a68a5.
Please also specify that commit's summary line in parens.
> The fix was to prevent the driver from re-reading the tun->numqueues
> more than once within tun_select_queue().
> We have been experiancing 'Divide-by-zero' errors in
> tun_net_xmit() since we moved from 3.6 to 3.10, and believe that they
> come from a simular source where the value of tun->numqueues changes
> to zero between the first and second read of tun->numqueues.
> Signed-off-by: Dominic Curran <dominic.curran@citrix.com>
> Cc: Jason Wang <jasowang@redhat.com>
> Cc: Maxim Krasnyansky <maxk@qualcomm.com>
WBR, Sergei
prev parent reply other threads:[~2014-01-18 17:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-18 0:26 [RFC PATCH] tuntap: Fix for a race in accessing numqueue Dominic Curran
2014-01-18 1:30 ` Eric Dumazet
2014-01-18 17:43 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52DABD35.3030408@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=dominic.curran@citrix.com \
--cc=jasowang@redhat.com \
--cc=maxk@qualcomm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).