From: Wang Weidong <wangweidong1@huawei.com>
To: Daniel Borkmann <dborkman@redhat.com>
Cc: <nhorman@tuxdriver.com>, <davem@davemloft.net>,
<vyasevich@gmail.com>, <netdev@vger.kernel.org>,
<linux-sctp@vger.kernel.org>
Subject: Re: [PATCH net-next 0/2] sctp: some small clean ups
Date: Mon, 20 Jan 2014 20:06:15 +0800 [thread overview]
Message-ID: <52DD1137.8040502@huawei.com> (raw)
In-Reply-To: <52DD0A62.9050807@redhat.com>
On 2014/1/20 19:37, Daniel Borkmann wrote:
> On 01/20/2014 12:27 PM, Wang Weidong wrote:
>> We have the macros in sctp.h, so use them for coding accordance
>> in sctp.
>
> Thanks for doing this Wang.
>
> I am actually wondering why we have these macro locking wrappers
Here, I didn't found any description about it. In v2.6.12-rc2, the sctp
use these macros.
> and not use these functions directly? Hm, any reasons? Maybe we
> should rather go in the other direction with this?
>
Yeah.
Should I do the other direction for clean ups now?
Regards,
Wang
>> Wang Weidong (2):
>> sctp: use sctp_local_bh_{disable|enable} instead
>> local_bh_{disable|enable}
>> sctp: use sctp_read_[un]lock instead of read_[un]lock
>>
>> net/sctp/endpointola.c | 4 ++--
>> net/sctp/input.c | 10 +++++-----
>> net/sctp/proc.c | 12 ++++++------
>> net/sctp/sm_make_chunk.c | 8 ++++----
>> net/sctp/socket.c | 8 ++++----
>> 5 files changed, 21 insertions(+), 21 deletions(-)
>>
>
>
next prev parent reply other threads:[~2014-01-20 12:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-20 11:27 [PATCH net-next 0/2] sctp: some small clean ups Wang Weidong
2014-01-20 11:27 ` [PATCH net-next 1/2] sctp: use sctp_local_bh_{disable|enable} instead local_bh_{disable|enable} Wang Weidong
2014-01-20 11:27 ` [PATCH net-next 2/2] sctp: use sctp_read_[un]lock instead of read_[un]lock Wang Weidong
2014-01-20 11:37 ` [PATCH net-next 0/2] sctp: some small clean ups Daniel Borkmann
2014-01-20 12:06 ` Wang Weidong [this message]
2014-01-20 12:20 ` Neil Horman
2014-01-20 12:32 ` Wang Weidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52DD1137.8040502@huawei.com \
--to=wangweidong1@huawei.com \
--cc=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).