netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Vito Caputo <vcaputo@pengaru.com>, davem@davemloft.net
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] net: core: skbuff: skb_checksum_setup() drop err
Date: Sun, 13 Oct 2019 12:58:04 -0700	[thread overview]
Message-ID: <52dfe9f3-cc54-408d-6781-3bc0a86ebae8@gmail.com> (raw)
In-Reply-To: <20191013003053.tmdc3hs73ik3asxq@shells.gnugeneration.com>



On 10/12/19 5:30 PM, Vito Caputo wrote:
> Return directly from all switch cases, no point in storing in err.
> 
> Signed-off-by: Vito Caputo <vcaputo@pengaru.com>
> ---
>  net/core/skbuff.c | 15 +++------------
>  1 file changed, 3 insertions(+), 12 deletions(-)
> 
> diff --git a/net/core/skbuff.c b/net/core/skbuff.c
> index f5f904f46893..c59b68a413b5 100644
> --- a/net/core/skbuff.c
> +++ b/net/core/skbuff.c
> @@ -4888,23 +4888,14 @@ static int skb_checksum_setup_ipv6(struct sk_buff *skb, bool recalculate)
>   */
>  int skb_checksum_setup(struct sk_buff *skb, bool recalculate)
>  {
> -	int err;
> -
>  	switch (skb->protocol) {
>  	case htons(ETH_P_IP):
> -		err = skb_checksum_setup_ipv4(skb, recalculate);
> -		break;
> -
> +		return skb_checksum_setup_ipv4(skb, recalculate);
>  	case htons(ETH_P_IPV6):
> -		err = skb_checksum_setup_ipv6(skb, recalculate);
> -		break;
> -
> +		return skb_checksum_setup_ipv6(skb, recalculate);
>  	default:
> -		err = -EPROTO;
> -		break;
> +		return -EPROTO;
>  	}
> -
> -	return err;
>  }
>  EXPORT_SYMBOL(skb_checksum_setup);


We prefer having a single return point in a function, if possible.

The err variable would make easier for debugging support,
if say a developer needs to trace this function.







  reply	other threads:[~2019-10-13 19:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-13  0:30 [PATCH] net: core: skbuff: skb_checksum_setup() drop err Vito Caputo
2019-10-13 19:58 ` Eric Dumazet [this message]
2019-10-13 20:17   ` Vito Caputo
2019-10-13 20:20     ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52dfe9f3-cc54-408d-6781-3bc0a86ebae8@gmail.com \
    --to=eric.dumazet@gmail.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=vcaputo@pengaru.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).