From: Christian Eggers <ceggers@arri.de>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: Richard Cochran <richardcochran@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
Vladimir Oltean <olteanv@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S . Miller" <davem@davemloft.net>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Kurt Kanzenbach <kurt@linutronix.de>
Subject: Re: [PATCH net-next v2 3/3] ptp: ptp_ines: use new PTP_MSGTYPE_* define(s)
Date: Thu, 19 Nov 2020 06:28:00 +0100 [thread overview]
Message-ID: <5337022.CNZMXmNBYT@n95hx1g2> (raw)
In-Reply-To: <5809d8e0-4848-004c-1551-691cd8bfbd67@intel.com>
On Wednesday, 18 November 2020, 22:03:56 CET, Jacob Keller wrote:
> On 11/18/2020 8:22 AM, Christian Eggers wrote:
> > Remove driver internal defines for this.
> >
> > Signed-off-by: Christian Eggers <ceggers@arri.de>
> > Cc: Richard Cochran <richardcochran@gmail.com>
> > Cc: Kurt Kanzenbach <kurt@linutronix.de>
> > ---
> >
> > drivers/ptp/ptp_ines.c | 19 +++++++------------
> > 1 file changed, 7 insertions(+), 12 deletions(-)
> >
> > diff --git a/drivers/ptp/ptp_ines.c b/drivers/ptp/ptp_ines.c
> > index 4700ffbdfced..6c7c2843ba0b 100644
> > --- a/drivers/ptp/ptp_ines.c
> > +++ b/drivers/ptp/ptp_ines.c
> > @@ -108,11 +108,6 @@ MODULE_LICENSE("GPL");
> >
> > #define MESSAGE_TYPE_P_DELAY_RESP 3
> > #define MESSAGE_TYPE_DELAY_REQ 4
> >
> > -#define SYNC 0x0
> > -#define DELAY_REQ 0x1
> > -#define PDELAY_REQ 0x2
> > -#define PDELAY_RESP 0x3
> > -
> >
> > static LIST_HEAD(ines_clocks);
> > static DEFINE_MUTEX(ines_clocks_lock);
> >
> > @@ -683,9 +678,9 @@ static bool is_sync_pdelay_resp(struct sk_buff *skb,
> > int type)>
> > msgtype = ptp_get_msgtype(hdr, type);
> >
> > - switch ((msgtype & 0xf)) {
> > - case SYNC:
> > - case PDELAY_RESP:
> > + switch (msgtype) {
> > + case PTP_MSGTYPE_SYNC:
>
> > + case PTP_MSGTYPE_PDELAY_RESP:
> This has a functional change of no longer discarding the higher bits of
> msgtype. While this may be correct, I think it should at least be called
> out as to why in the commit message.
The "& 0xf" is already done within ptp_get_msgtype(). I will add this to the
commit description for the next series.
regards
Christian
prev parent reply other threads:[~2020-11-19 5:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-18 16:22 [PATCH net-next v2 0/3] net: ptp: introduce common defines for PTP message types Christian Eggers
2020-11-18 16:22 ` [PATCH net-next v2 1/3] " Christian Eggers
2020-11-18 16:22 ` [PATCH net-next v2 2/3] dpaa2-eth: use new PTP_MSGTYPE_* define(s) Christian Eggers
2020-11-18 16:22 ` [PATCH net-next v2 3/3] ptp: ptp_ines: " Christian Eggers
2020-11-18 21:03 ` Jacob Keller
2020-11-19 5:28 ` Christian Eggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5337022.CNZMXmNBYT@n95hx1g2 \
--to=ceggers@arri.de \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=jacob.e.keller@intel.com \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).