From: Ben Greear <greearb@candelatech.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] macvlan: Move broadcasts into a work queue
Date: Tue, 08 Apr 2014 09:48:40 -0700 [thread overview]
Message-ID: <53442868.3090701@candelatech.com> (raw)
In-Reply-To: <20140407142334.GA28814@gondor.apana.org.au>
On 04/07/2014 07:23 AM, Herbert Xu wrote:
> On Mon, Apr 07, 2014 at 07:07:42AM -0700, Eric Dumazet wrote:
>>
>> I suppose its a net-next material ?
>
> Oh yes absolutely.
>
>> Memory allocations (one incoming message -> ~4096 duplications) probably
>> should use GFP_KERNEL. This might need a change from rcu to simple mutex
>> for macvlan_broadcast() scan of all macvlans.
>
> Good point. However, as this change will be non-trivial we can
> do this as a follow-up.
>
>> cond_resched() could help macvlan_process_broadcast() to not hog cpu.
>>
>> Anyway, 4.000 incoming messages are duplicated into 16.000.000 messages,
>> it takes half a minute to process on a single cpu. You might need
>> multiple workqueue to split the load on all online cpus ;)
>
> You're welcome to add further improvements :)
At least for ARPs, maybe we could inspect the packet and only
deliver to interfaces configured with the MAC that is being
ARPed for (or ones that are in promisc)?
This would need to be a configurable optimization probably,
since perhaps someone depends on the current behaviour....
Thanks,
Ben
>
> Thanks,
>
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2014-04-08 16:48 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <<20140407075347.GA26461@gondor.apana.org.au>
2014-04-07 7:55 ` [PATCH 1/2] net: Add __dev_forward_skb Herbert Xu
2014-04-07 18:48 ` Stephen Hemminger
2014-04-08 7:15 ` Herbert Xu
2014-04-08 16:27 ` David Miller
2014-04-07 7:55 ` [PATCH 2/2] macvlan: Move broadcasts into a work queue Herbert Xu
2014-04-07 14:07 ` Eric Dumazet
2014-04-07 14:23 ` Herbert Xu
2014-04-08 16:48 ` Ben Greear [this message]
2014-04-08 17:23 ` Herbert Xu
2014-04-11 1:40 ` David Miller
2014-04-11 1:59 ` Herbert Xu
2014-04-11 2:09 ` Eric Dumazet
2014-04-11 2:13 ` Herbert Xu
2014-04-11 8:45 ` David Laight
2014-04-11 16:11 ` Ben Greear
2014-04-11 16:20 ` Ben Greear
2014-04-11 16:17 ` Ben Greear
2014-04-08 16:55 ` Stephen Hemminger
2014-04-08 17:14 ` Joe Perches
2014-04-09 8:50 ` Herbert Xu
2014-04-09 10:10 ` David Laight
2014-04-10 12:59 ` Herbert Xu
2014-04-10 14:50 ` David Laight
2014-04-07 7:53 [0/2] macvlan: Handle broadcasts in " Herbert Xu
2014-04-17 5:45 ` [PATCH 1/2] net: Add __dev_forward_skb Herbert Xu
2014-04-20 22:19 ` David Miller
2014-04-17 5:45 ` [PATCH 2/2] macvlan: Move broadcasts into a work queue Herbert Xu
2014-04-20 22:20 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53442868.3090701@candelatech.com \
--to=greearb@candelatech.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).