From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Larry Finger <Larry.Finger@lwfinger.net>, gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, netdev@vger.kernel.org,
Stable <stable@vger.kernel.org>
Subject: Re: [PATCH 3/3] staging: r8712u: Fix case where ethtype was never obtained and always be checked against 0
Date: Wed, 09 Apr 2014 20:25:50 +0400 [thread overview]
Message-ID: <5345748E.7050908@cogentembedded.com> (raw)
In-Reply-To: <1397059980-11942-4-git-send-email-Larry.Finger@lwfinger.net>
On 04/09/2014 08:13 PM, Larry Finger wrote:
> Zero-initializing ether_type masked that the ether type would never be
> obtained for 8021x packets and the comparition against eapol_type
> would always fail.
> Reported-by: Jes Sorensen <Jes.Sorensen@redhat.com>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> Cc: Stable <stable@vger.kernel.org>
> ---
> drivers/staging/rtl8712/rtl871x_recv.c | 15 +++++++--------
> 1 file changed, 7 insertions(+), 8 deletions(-)
> diff --git a/drivers/staging/rtl8712/rtl871x_recv.c b/drivers/staging/rtl8712/rtl871x_recv.c
> index 23ec684..d8d1a76 100644
> --- a/drivers/staging/rtl8712/rtl871x_recv.c
> +++ b/drivers/staging/rtl8712/rtl871x_recv.c
[...]
> @@ -262,16 +262,15 @@ union recv_frame *r8712_portctrl(struct _adapter *adapter,
> psta_addr = pfhdr->attrib.ta;
> psta = r8712_get_stainfo(pstapriv, psta_addr);
> auth_alg = adapter->securitypriv.AuthAlgrthm;
> - if (auth_alg == 2) {
> + if (auth_alg == dot11AuthAlgrthm_8021X) {
> + /* get ether_type */
> + ptr = ptr + pfhdr->attrib.hdrlen + LLC_HEADER_SIZE;
Why not:
ptr += pfhdr->attrib.hdrlen + LLC_HEADER_SIZE;
WBR, Sergei
next prev parent reply other threads:[~2014-04-09 16:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-09 16:12 [PATCH 0/3] Fix some bugs in staging drivers Larry Finger
2014-04-09 16:12 ` [PATCH 1/3] staging: r8188eu: Calling rtw_get_stainfo() with a NULL sta_addr will return NULL Larry Finger
2014-04-09 16:12 ` [PATCH 2/3] staging: r8188eu: Fix case where ethtype was never obtained and always be checked against 0 Larry Finger
2014-04-09 16:24 ` Sergei Shtylyov
2014-04-09 17:44 ` Larry Finger
2014-04-09 19:02 ` Dan Carpenter
2014-04-09 19:11 ` Sergei Shtylyov
2014-04-09 19:44 ` Dan Carpenter
2014-04-09 18:51 ` Dan Carpenter
2014-04-09 19:00 ` Dan Carpenter
2014-04-10 9:14 ` David Laight
2014-04-16 18:45 ` Greg KH
2014-04-09 16:13 ` [PATCH 3/3] staging: r8712u: " Larry Finger
2014-04-09 16:25 ` Sergei Shtylyov [this message]
2014-04-09 17:45 ` Larry Finger
2014-04-16 18:46 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5345748E.7050908@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).