From: Shaokun Zhang <zhangshaokun@hisilicon.com>
To: Eric Dumazet <edumazet@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Eric Dumazet <eric.dumazet@gmail.com>,
David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>, <jinyuqi@huawei.com>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
"Hideaki YOSHIFUJI" <yoshfuji@linux-ipv6.org>,
<guoyang2@huawei.com>, Will Deacon <will@kernel.org>
Subject: Re: [PATCH] net: optimize cmpxchg in ip_idents_reserve
Date: Tue, 21 Jan 2020 10:40:11 +0800 [thread overview]
Message-ID: <5377f988-9855-8322-a459-26376f50ee34@hisilicon.com> (raw)
In-Reply-To: <CANn89iJ02iFxGibdqO+YWVYX4q4J=W9vv7HOpMVqNK-qZvHcQw@mail.gmail.com>
Hi Eric,
On 2020/1/19 12:12, Eric Dumazet wrote:
> On Sat, Jan 18, 2020 at 7:47 PM Shaokun Zhang
> <zhangshaokun@hisilicon.com> wrote:
>>
>
>> We have used the atomic_add_return[1], but it makes the UBSAN unhappy followed
>> by the comment.
>> It seems that Eric also agreed to do it if some comments are added. I will do
>> it later.
>>
>> Thanks,
>> Shaokun
>>
>> [1] https://lkml.org/lkml/2019/7/26/217
>>
>
> In case you have missed it, we needed a proper analysis.
> My feedback was quite simple :
>
> <quote>
> Have you first checked that current UBSAN versions will not complain anymore ?
> </quote>
>
> You never did this work, never replied to my question, and months
Yeah, I'm not sure how to deal with the UBSAN issue and you said that some of
you would work this.
> later you come back
> with a convoluted patch while we simply can proceed with a revert now
After several months, we thought that we can do it like refcount_add_not_zero,
so we submit this patch.
> we are sure that linux kernels are compiled with the proper option.
>
> As mentioned yesterday, no need for a comment.
> Instead the changelog should be explaining why the revert is now safe.
>
Ok, it is really needed to consider this.
Thanks,
Shaokun
> .
>
next prev parent reply other threads:[~2020-01-21 2:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 3:23 [PATCH] net: optimize cmpxchg in ip_idents_reserve Shaokun Zhang
2020-01-16 12:27 ` David Miller
2020-01-16 14:05 ` Shaokun Zhang
2020-01-16 15:12 ` Eric Dumazet
2020-01-16 15:19 ` Eric Dumazet
2020-01-17 6:54 ` Shaokun Zhang
2020-01-17 12:32 ` Peter Zijlstra
2020-01-17 16:35 ` Eric Dumazet
2020-01-17 18:03 ` Arvind Sankar
2020-01-17 18:16 ` Eric Dumazet
2020-01-17 18:38 ` Arvind Sankar
2020-01-17 18:48 ` Eric Dumazet
2020-01-20 8:18 ` Peter Zijlstra
2020-05-07 9:12 ` Shaokun Zhang
2020-05-07 13:49 ` Eric Dumazet
2020-01-19 3:46 ` Shaokun Zhang
2020-01-19 4:12 ` Eric Dumazet
2020-01-21 2:40 ` Shaokun Zhang [this message]
2020-01-22 8:49 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5377f988-9855-8322-a459-26376f50ee34@hisilicon.com \
--to=zhangshaokun@hisilicon.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=guoyang2@huawei.com \
--cc=jinyuqi@huawei.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).