From: Thierry Herbelot <thierry.herbelot@6wind.com>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>,
Bruce Allan <bruce.w.allan@intel.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH v2] ixgbe: check adapter->vfinfo before dereference
Date: Fri, 10 Oct 2014 10:53:18 +0200 [thread overview]
Message-ID: <54379E7E.9070103@6wind.com> (raw)
In-Reply-To: <1412931052.2427.33.camel@jtkirshe-mobl>
On 10/10/2014 10:50 AM, Jeff Kirsher wrote:
> On Fri, 2014-10-10 at 10:45 +0200, Thierry Herbelot wrote:
>> this protects against the following panic:
>> (before a VF was actually created on p96p1 PF Ethernet port)
>> ip link set p96p1 vf 0 spoofchk off
>> BUG: unable to handle kernel NULL pointer dereference at
>> 0000000000000052
>> IP: [<ffffffffa044a1c1>] ixgbe_ndo_set_vf_spoofchk+0x51/0x150 [ixgbe]
>>
>> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
>> ---
>> drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 73
>> +++++++++++++++++++++++-
>> 1 file changed, 70 insertions(+), 3 deletions(-)
>
> Thanks for fixing that up Thierry. I have added your patch to my queue.
Sorry for the miscompile : I wrote the patch back in August, and left it
to rot while doing other things and I did not check it was really
correct before sending it yesterday.
Thierry
>
--
Thierry Herbelot
6WIND
Software Engineer
next prev parent reply other threads:[~2014-10-10 8:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-10 8:45 [PATCH v2] ixgbe: check adapter->vfinfo before dereference Thierry Herbelot
2014-10-10 8:50 ` Jeff Kirsher
2014-10-10 8:53 ` Thierry Herbelot [this message]
2014-10-14 23:18 ` Tantilov, Emil S
2014-10-15 9:58 ` [PATCH v3 net] " Thierry Herbelot
2014-10-15 11:00 ` Jeff Kirsher
2014-10-15 22:50 ` Tantilov, Emil S
2014-10-16 7:23 ` Thierry Herbelot
2014-10-16 7:32 ` Jeff Kirsher
2014-10-16 7:34 ` Thierry Herbelot
2014-10-16 7:36 ` Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54379E7E.9070103@6wind.com \
--to=thierry.herbelot@6wind.com \
--cc=bruce.w.allan@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).