From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Cc: "Antoine Ténart" <antoine.tenart@free-electrons.com>,
"David S. Miller" <davem@davemloft.net>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Eric Miao" <eric.y.miao@gmail.com>,
"Haojian Zhuang" <haojian.zhuang@gmail.com>,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 8/9] ARM: berlin: Add phy-connection-type to BG2Q PHY
Date: Tue, 21 Oct 2014 15:31:13 +0400 [thread overview]
Message-ID: <54464401.20900@cogentembedded.com> (raw)
In-Reply-To: <1413881627-21639-9-git-send-email-sebastian.hesselbarth@gmail.com>
Hello.
On 10/21/2014 12:53 PM, Sebastian Hesselbarth wrote:
> From: Antoine Ténart <antoine.tenart@free-electrons.com>
> Internal FastEthernet PHY on BG2Q is connected via MII, add a
> corresponding phy-connection-type property.
> Tested-by: Antoine Ténart <antoine.tenart@free-electrons.com>
> Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> ---
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: "Antoine Ténart" <antoine.tenart@free-electrons.com>
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Cc: Eric Miao <eric.y.miao@gmail.com>
> Cc: Haojian Zhuang <haojian.zhuang@gmail.com>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: netdev@vger.kernel.org
> Cc: devicetree@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> ---
> arch/arm/boot/dts/berlin2q.dtsi | 1 +
> 1 file changed, 1 insertion(+)
> diff --git a/arch/arm/boot/dts/berlin2q.dtsi b/arch/arm/boot/dts/berlin2q.dtsi
> index 891d56b03922..6dbc520bddc1 100644
> --- a/arch/arm/boot/dts/berlin2q.dtsi
> +++ b/arch/arm/boot/dts/berlin2q.dtsi
> @@ -127,6 +127,7 @@
> status = "disabled";
>
> ethphy0: ethernet-phy@0 {
> + phy-connection-type = "mii";
You're adding this prop to the PHY node? That's very weird... normally,
it's a property of a MDIO bus node.
[...]
WBR, Sergei
next prev parent reply other threads:[~2014-10-21 11:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-21 8:53 [PATCH 0/9] Marvell PXA168 libphy handling and Berlin Ethernet Sebastian Hesselbarth
2014-10-21 8:53 ` [PATCH 1/9] phy: marvell: Add support for 88E3016 FastEthernet PHY Sebastian Hesselbarth
2014-10-21 8:53 ` [PATCH 2/9] net: pxa168_eth: Provide phy_interface mode on platform_data Sebastian Hesselbarth
2014-10-21 8:53 ` [PATCH 3/9] net: pxa168_eth: Prepare proper libphy handling Sebastian Hesselbarth
2014-10-21 8:53 ` [PATCH 4/9] net: pxa168_eth: Remove HW auto-negotiaion Sebastian Hesselbarth
2014-10-21 8:53 ` [PATCH 5/9] net: pxa168_eth: Remove in-driver PHY mangling Sebastian Hesselbarth
2014-10-21 8:53 ` [PATCH 6/9] ARM: berlin: Add BG2 ethernet DT nodes Sebastian Hesselbarth
2014-10-21 8:53 ` [PATCH 7/9] ARM: berlin: Add BG2CD " Sebastian Hesselbarth
2014-10-21 8:53 ` [PATCH 8/9] ARM: berlin: Add phy-connection-type to BG2Q PHY Sebastian Hesselbarth
2014-10-21 11:31 ` Sergei Shtylyov [this message]
2014-10-21 11:46 ` Sebastian Hesselbarth
2014-10-21 12:08 ` Sergei Shtylyov
2014-10-21 8:53 ` [PATCH 9/9] ARM: berlin: Enable ethernet on Sony NSZ-GS7 Sebastian Hesselbarth
2014-10-21 22:03 ` [PATCH 0/9] Marvell PXA168 libphy handling and Berlin Ethernet Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54464401.20900@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=antoine.tenart@free-electrons.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=eric.y.miao@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=haojian.zhuang@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).