From: SF Markus Elfring <elfring@users.sourceforge.net>
To: "David S. Miller" <davem@davemloft.net>,
Paul Moore <paul@paul-moore.com>,
netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Julia Lawall <julia.lawall@lip6.fr>
Subject: [PATCH v3 3/3] netlabel: Less function calls in netlbl_mgmt_add_common() after error detection
Date: Mon, 02 Feb 2015 12:06:39 +0100 [thread overview]
Message-ID: <54CF5A3F.6080600@users.sourceforge.net> (raw)
In-Reply-To: <54CF4FEC.2010906@users.sourceforge.net>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 2 Feb 2015 11:00:24 +0100
The functions "cipso_v4_doi_putdef" and "kfree" could be called in some cases
by the netlbl_mgmt_add_common() function during error handling even if the
passed variables contained still a null pointer.
* This implementation detail could be improved by adjustments for jump labels.
* Let us return immediately after the first failed function call according to
the current Linux coding style convention.
* Let us delete also an unnecessary check for the variable "entry" there.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Acked-by: Paul Moore <paul@paul-moore.com>
---
net/netlabel/netlabel_mgmt.c | 49 ++++++++++++++++++++++----------------------
1 file changed, 24 insertions(+), 25 deletions(-)
diff --git a/net/netlabel/netlabel_mgmt.c b/net/netlabel/netlabel_mgmt.c
index f5807f5..7044074 100644
--- a/net/netlabel/netlabel_mgmt.c
+++ b/net/netlabel/netlabel_mgmt.c
@@ -93,23 +93,20 @@ static int netlbl_mgmt_add_common(struct genl_info *info,
struct netlbl_audit *audit_info)
{
int ret_val = -EINVAL;
- struct netlbl_dom_map *entry = NULL;
struct netlbl_domaddr_map *addrmap = NULL;
struct cipso_v4_doi *cipsov4 = NULL;
u32 tmp_val;
+ struct netlbl_dom_map *entry = kzalloc(sizeof(*entry), GFP_KERNEL);
- entry = kzalloc(sizeof(*entry), GFP_KERNEL);
- if (entry == NULL) {
- ret_val = -ENOMEM;
- goto add_failure;
- }
+ if (!entry)
+ return -ENOMEM;
entry->def.type = nla_get_u32(info->attrs[NLBL_MGMT_A_PROTOCOL]);
if (info->attrs[NLBL_MGMT_A_DOMAIN]) {
size_t tmp_size = nla_len(info->attrs[NLBL_MGMT_A_DOMAIN]);
entry->domain = kmalloc(tmp_size, GFP_KERNEL);
if (entry->domain == NULL) {
ret_val = -ENOMEM;
- goto add_failure;
+ goto add_free_entry;
}
nla_strlcpy(entry->domain,
info->attrs[NLBL_MGMT_A_DOMAIN], tmp_size);
@@ -125,16 +122,16 @@ static int netlbl_mgmt_add_common(struct genl_info *info,
break;
case NETLBL_NLTYPE_CIPSOV4:
if (!info->attrs[NLBL_MGMT_A_CV4DOI])
- goto add_failure;
+ goto add_free_domain;
tmp_val = nla_get_u32(info->attrs[NLBL_MGMT_A_CV4DOI]);
cipsov4 = cipso_v4_doi_getdef(tmp_val);
if (cipsov4 == NULL)
- goto add_failure;
+ goto add_free_domain;
entry->def.cipso = cipsov4;
break;
default:
- goto add_failure;
+ goto add_free_domain;
}
if (info->attrs[NLBL_MGMT_A_IPV4ADDR]) {
@@ -145,7 +142,7 @@ static int netlbl_mgmt_add_common(struct genl_info *info,
addrmap = kzalloc(sizeof(*addrmap), GFP_KERNEL);
if (addrmap == NULL) {
ret_val = -ENOMEM;
- goto add_failure;
+ goto add_doi_put_def;
}
INIT_LIST_HEAD(&addrmap->list4);
INIT_LIST_HEAD(&addrmap->list6);
@@ -153,12 +150,12 @@ static int netlbl_mgmt_add_common(struct genl_info *info,
if (nla_len(info->attrs[NLBL_MGMT_A_IPV4ADDR]) !=
sizeof(struct in_addr)) {
ret_val = -EINVAL;
- goto add_failure;
+ goto add_free_addrmap;
}
if (nla_len(info->attrs[NLBL_MGMT_A_IPV4MASK]) !=
sizeof(struct in_addr)) {
ret_val = -EINVAL;
- goto add_failure;
+ goto add_free_addrmap;
}
addr = nla_data(info->attrs[NLBL_MGMT_A_IPV4ADDR]);
mask = nla_data(info->attrs[NLBL_MGMT_A_IPV4MASK]);
@@ -166,7 +163,7 @@ static int netlbl_mgmt_add_common(struct genl_info *info,
map = kzalloc(sizeof(*map), GFP_KERNEL);
if (map == NULL) {
ret_val = -ENOMEM;
- goto add_failure;
+ goto add_free_addrmap;
}
map->list.addr = addr->s_addr & mask->s_addr;
map->list.mask = mask->s_addr;
@@ -178,7 +175,7 @@ static int netlbl_mgmt_add_common(struct genl_info *info,
ret_val = netlbl_af4list_add(&map->list, &addrmap->list4);
if (ret_val != 0) {
kfree(map);
- goto add_failure;
+ goto add_free_addrmap;
}
entry->def.type = NETLBL_NLTYPE_ADDRSELECT;
@@ -192,7 +189,7 @@ static int netlbl_mgmt_add_common(struct genl_info *info,
addrmap = kzalloc(sizeof(*addrmap), GFP_KERNEL);
if (addrmap == NULL) {
ret_val = -ENOMEM;
- goto add_failure;
+ goto add_doi_put_def;
}
INIT_LIST_HEAD(&addrmap->list4);
INIT_LIST_HEAD(&addrmap->list6);
@@ -200,12 +197,12 @@ static int netlbl_mgmt_add_common(struct genl_info *info,
if (nla_len(info->attrs[NLBL_MGMT_A_IPV6ADDR]) !=
sizeof(struct in6_addr)) {
ret_val = -EINVAL;
- goto add_failure;
+ goto add_free_addrmap;
}
if (nla_len(info->attrs[NLBL_MGMT_A_IPV6MASK]) !=
sizeof(struct in6_addr)) {
ret_val = -EINVAL;
- goto add_failure;
+ goto add_free_addrmap;
}
addr = nla_data(info->attrs[NLBL_MGMT_A_IPV6ADDR]);
mask = nla_data(info->attrs[NLBL_MGMT_A_IPV6MASK]);
@@ -213,7 +210,7 @@ static int netlbl_mgmt_add_common(struct genl_info *info,
map = kzalloc(sizeof(*map), GFP_KERNEL);
if (map == NULL) {
ret_val = -ENOMEM;
- goto add_failure;
+ goto add_free_addrmap;
}
map->list.addr = *addr;
map->list.addr.s6_addr32[0] &= mask->s6_addr32[0];
@@ -227,7 +224,7 @@ static int netlbl_mgmt_add_common(struct genl_info *info,
ret_val = netlbl_af6list_add(&map->list, &addrmap->list6);
if (ret_val != 0) {
kfree(map);
- goto add_failure;
+ goto add_free_addrmap;
}
entry->def.type = NETLBL_NLTYPE_ADDRSELECT;
@@ -237,15 +234,17 @@ static int netlbl_mgmt_add_common(struct genl_info *info,
ret_val = netlbl_domhsh_add(entry, audit_info);
if (ret_val != 0)
- goto add_failure;
+ goto add_free_addrmap;
return 0;
-add_failure:
- cipso_v4_doi_putdef(cipsov4);
- if (entry)
- kfree(entry->domain);
+add_free_addrmap:
kfree(addrmap);
+add_doi_put_def:
+ cipso_v4_doi_putdef(cipsov4);
+add_free_domain:
+ kfree(entry->domain);
+add_free_entry:
kfree(entry);
return ret_val;
}
--
2.2.2
next prev parent reply other threads:[~2015-02-02 11:06 UTC|newest]
Thread overview: 273+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5307CAA2.8060406@users.sourceforge.net>
[not found] ` <alpine.DEB.2.02.1402212321410.2043@localhost6.localdomain6>
[not found] ` <530A086E.8010901@users.sourceforge.net>
[not found] ` <alpine.DEB.2.02.1402231635510.1985@localhost6.localdomain6>
[not found] ` <530A72AA.3000601@users.sourceforge.net>
[not found] ` <alpine.DEB.2.02.1402240658210.2090@localhost6.localdomain6>
[not found] ` <530B5FB6.6010207@users.sourceforge.net>
[not found] ` <alpine.DEB.2.10.1402241710370.2074@hadrien>
[not found] ` <530C5E18.1020800@users.sourceforge.net>
[not found] ` <alpine.DEB.2.10.1402251014170.2080@hadrien>
[not found] ` <530CD2C4.4050903@users.sourceforge.net>
[not found] ` <alpine.DEB.2.10.1402251840450.7035@hadrien>
[not found] ` <530CF8FF.8080600@users.sourceforge.net>
[not found] ` <alpine.DEB.2.02.1402252117150.2047@localhost6.localdomain6>
[not found] ` <530DD06F.4090703@users.sourceforge.net>
[not found] ` <alpine.DEB.2.02.1402262129250.2221@localhost6.localdomain6>
[not found] ` <5317A59D.4@users.so urceforge.net>
[not found] ` <5317A59D.4-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
2015-02-04 14:22 ` [PATCH] net: Mellanox: Delete unnecessary checks before the function call "vunmap" SF Markus Elfring
2015-02-04 14:59 ` Eli Cohen
[not found] ` <54D22B29.3020200-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
2015-02-05 8:34 ` David Miller
[not found] ` <20150205.003404.261962007607296519.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2015-02-09 10:21 ` [PATCH v2] " SF Markus Elfring
2015-02-09 22:10 ` David Miller
2015-11-15 8:40 ` [PATCH 0/2] batman-adv: Deletion of some unnecessary checks SF Markus Elfring
2015-11-15 8:43 ` [PATCH 1/2] batman-adv: Delete unnecessary checks before the function call "kfree_skb" SF Markus Elfring
2015-11-21 21:45 ` [B.A.T.M.A.N.] " Marek Lindner
2015-11-15 8:45 ` [PATCH 2/2] batman-adv: Less checks in batadv_tvlv_unicast_send() SF Markus Elfring
2015-11-21 21:47 ` [B.A.T.M.A.N.] " Marek Lindner
[not found] ` <5317A59D.4@users.sourceforge.net>
2014-11-18 19:16 ` [PATCH 1/1] net: pktgen: Deletion of an unnecessary check before the function call "proc_remove" SF Markus Elfring
2014-11-19 20:20 ` David Miller
2014-11-18 19:47 ` [PATCH 1/1] netfilter: Deletion of unnecessary checks before two function calls SF Markus Elfring
2014-11-19 13:40 ` Pablo Neira Ayuso
2015-07-02 15:10 ` [PATCH] net-ipvs: Delete an unnecessary check before the function call "module_put" SF Markus Elfring
2015-07-09 1:41 ` Simon Horman
2014-11-19 22:26 ` [PATCH 1/1] netfilter: Deletion of unnecessary checks before two function calls Julian Anastasov
2014-11-20 1:13 ` Simon Horman
2014-11-20 12:16 ` Pablo Neira Ayuso
2014-11-18 20:08 ` [PATCH 1/1] netlink: Deletion of an unnecessary check before the function call "__module_get" SF Markus Elfring
2014-11-19 20:28 ` David Miller
2014-11-18 20:26 ` [PATCH 1/1] net: sched: Deletion of an unnecessary check before the function call "kfree" SF Markus Elfring
2014-11-19 16:47 ` John Fastabend
2014-11-19 17:00 ` Daniel Borkmann
2014-11-19 18:49 ` SF Markus Elfring
2014-11-19 19:09 ` Daniel Borkmann
2014-11-20 8:47 ` Julia Lawall
2014-11-20 9:22 ` Daniel Borkmann
2014-11-18 20:45 ` [PATCH 1/1] net: xfrm: Deletion of an unnecessary check before the function call "ipcomp_free_tfms" SF Markus Elfring
2014-11-19 8:45 ` Dan Carpenter
2014-11-19 9:51 ` SF Markus Elfring
2014-11-19 9:58 ` Julia Lawall
2014-11-19 10:10 ` Dan Carpenter
2014-11-19 18:19 ` David Miller
2014-11-19 19:55 ` [PATCH 1/1] mISDN: Deletion of unnecessary checks before the function call "vfree" SF Markus Elfring
2014-11-19 21:54 ` David Miller
2014-11-20 13:28 ` [PATCH 1/1] IBM-EMAC: Deletion of unnecessary checks before the function call "of_dev_put" SF Markus Elfring
2014-11-21 20:14 ` David Miller
2014-11-20 13:50 ` [PATCH 1/1] net: Xilinx: Deletion of unnecessary checks before two function calls SF Markus Elfring
2014-11-20 17:29 ` Sören Brinkmann
2014-11-21 20:14 ` David Miller
2014-11-20 14:25 ` [PATCH 1/1] net: Hyper-V: Deletion of an unnecessary check before the function call "vfree" SF Markus Elfring
2014-11-20 18:58 ` Haiyang Zhang
2014-11-21 20:15 ` David Miller
2014-11-21 22:15 ` SF Markus Elfring
2014-11-21 22:27 ` David Miller
2014-11-23 0:51 ` SF Markus Elfring
2014-11-23 1:27 ` Eric Dumazet
2014-11-23 7:01 ` SF Markus Elfring
2014-11-23 4:36 ` David Miller
2014-11-23 7:18 ` SF Markus Elfring
2014-11-23 18:37 ` David Miller
2014-11-25 21:55 ` [PATCH v2] " SF Markus Elfring
2014-11-25 22:25 ` David Miller
2014-11-20 15:16 ` [PATCH 1/1] net: USB: Deletion of unnecessary checks before the function call "kfree" SF Markus Elfring
2014-11-21 20:16 ` David Miller
2014-11-20 15:50 ` [PATCH 1/1] net: brcm80211: Deletion of unnecessary checks before two function calls SF Markus Elfring
2014-11-20 18:04 ` Arend van Spriel
2015-11-06 7:58 ` [PATCH] net: brcm80211: Delete an unnecessary check before the function call "release_firmware" SF Markus Elfring
2015-11-11 9:18 ` Arend van Spriel
[not found] ` <563C5DA2.3000005-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
2015-11-26 12:04 ` brcm80211: Delete an unnecessary check before the function call"release_firmware" Kalle Valo
2014-11-29 13:42 ` [PATCH 1/1] HID: Wacom: Deletion of an unnecessary check before the function call "vfree" SF Markus Elfring
2014-11-29 14:05 ` [PATCH 1/1] net: cassini: " SF Markus Elfring
2014-12-06 5:14 ` David Miller
2014-11-29 15:30 ` [PATCH 1/1] net-ipvlan: Deletion of an unnecessary check before the function call "free_percpu" SF Markus Elfring
2014-12-02 0:01 ` Mahesh Bandewar
2014-12-06 5:14 ` David Miller
2014-11-29 18:00 ` [PATCH 1/1] net-PA Semi: Deletion of unnecessary checks before the function call "pci_dev_put" SF Markus Elfring
2014-11-30 17:45 ` Lino Sanfilippo
2014-11-30 17:47 ` Julia Lawall
2014-11-30 19:27 ` Lino Sanfilippo
2014-11-30 20:40 ` SF Markus Elfring
2014-11-30 21:36 ` Lino Sanfilippo
[not found] ` <547B579F.10709-Mmb7MZpHnFY@public.gmane.org>
2014-12-01 1:34 ` SF Markus Elfring
2014-12-01 20:29 ` Johannes Berg
2014-12-01 20:34 ` Julia Lawall
[not found] ` <alpine.DEB.2.02.1412012134290.2076-bi+AKbBUZKagILUCTcTcHdKyNwTtLsGr@public.gmane.org>
2014-12-02 16:53 ` Johannes Berg
[not found] ` <1417539208.1841.1.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2014-12-02 18:35 ` Dan Carpenter
2014-12-02 20:18 ` Luis R. Rodriguez
2014-12-02 18:45 ` Luis R. Rodriguez
2014-12-01 20:36 ` [PATCH 1/1] " Olof Johansson
2014-12-06 5:15 ` David Miller
2014-11-30 16:40 ` [PATCH 0/3] net-PPP: Deletion of a few unnecessary checks SF Markus Elfring
2014-11-30 16:44 ` [PATCH 1/3] net-PPP: Deletion of unnecessary checks before the function call "kfree" SF Markus Elfring
2014-12-01 12:19 ` Sergei Shtylyov
2014-12-01 15:00 ` SF Markus Elfring
2014-12-01 17:11 ` Sergei Shtylyov
2014-12-04 22:03 ` [PATCH v2 0/6] net-PPP: Deletion of a few unnecessary checks SF Markus Elfring
2014-12-04 22:10 ` [PATCH v2 1/6] net-PPP: Replacement of a printk() call by pr_warn() in mppe_rekey() SF Markus Elfring
2014-12-04 22:23 ` Joe Perches
2014-12-04 22:27 ` SF Markus Elfring
2014-12-04 22:45 ` Joe Perches
2014-12-05 6:26 ` Julia Lawall
2014-12-05 8:04 ` SF Markus Elfring
2014-12-05 8:40 ` Julia Lawall
2014-12-05 7:18 ` SF Markus Elfring
2014-12-05 7:57 ` Joe Perches
2014-12-05 8:49 ` SF Markus Elfring
2014-12-05 22:35 ` terry white
2014-12-05 7:21 ` Julia Lawall
2014-12-05 7:41 ` Joe Perches
2014-12-07 10:44 ` Julia Lawall
2014-12-07 12:30 ` Joe Perches
2014-12-07 12:36 ` Julia Lawall
2014-12-07 12:42 ` Joe Perches
2014-12-04 22:13 ` [PATCH v2 2/6] net-PPP: Fix indentation SF Markus Elfring
2014-12-04 22:15 ` [PATCH v2 3/6] net-PPP: Deletion of unnecessary checks before the function call "kfree" SF Markus Elfring
2014-12-04 22:16 ` [PATCH v2 4/6] net-PPP: Less function calls in mppe_alloc() after error detection SF Markus Elfring
2014-12-04 22:18 ` [PATCH v2 5/6] net-PPP: Delete an unnecessary assignment in mppe_alloc() SF Markus Elfring
2014-12-05 12:22 ` Dan Carpenter
2014-12-05 12:44 ` SF Markus Elfring
2014-12-05 13:57 ` Dan Carpenter
2014-12-05 21:00 ` SF Markus Elfring
2014-12-04 22:20 ` [PATCH v2 6/6] net-PPP: Delete another " SF Markus Elfring
2014-12-05 12:23 ` Dan Carpenter
2014-12-05 12:50 ` SF Markus Elfring
2014-12-05 13:58 ` Dan Carpenter
2014-12-09 19:54 ` [PATCH v2 0/6] net-PPP: Deletion of a few unnecessary checks David Miller
2014-12-12 7:01 ` SF Markus Elfring
2014-12-12 14:29 ` David Miller
2014-12-12 15:30 ` SF Markus Elfring
2014-12-12 15:51 ` David Miller
2014-12-12 16:56 ` SF Markus Elfring
2014-12-12 16:59 ` David Miller
2014-12-12 17:22 ` SF Markus Elfring
2014-12-12 19:08 ` Eric Dumazet
2014-12-13 6:05 ` SF Markus Elfring
2014-12-12 20:07 ` David Miller
2014-12-13 6:17 ` SF Markus Elfring
2014-12-18 17:23 ` SF Markus Elfring
2014-12-18 17:25 ` David Miller
2014-12-18 17:44 ` SF Markus Elfring
2014-12-20 14:45 ` SF Markus Elfring
2014-12-20 15:48 ` Lino Sanfilippo
2014-12-20 16:17 ` SF Markus Elfring
2014-12-20 19:30 ` David Miller
2014-12-12 18:46 ` Julia Lawall
2014-11-30 16:45 ` [PATCH 2/3] net-PPP: Less function calls in mppe_alloc() after error detection SF Markus Elfring
2014-11-30 16:47 ` [PATCH 3/3] net-PPP: Delete an unnecessary assignment SF Markus Elfring
2014-11-30 19:59 ` Eric Dumazet
2014-11-30 21:16 ` SF Markus Elfring
2015-01-31 16:34 ` [PATCH] net: sched: One function call less in em_meta_change() after error detection SF Markus Elfring
2015-01-31 17:31 ` Lino Sanfilippo
2015-01-31 21:48 ` SF Markus Elfring
2015-01-31 22:15 ` Lino Sanfilippo
2015-01-31 22:20 ` SF Markus Elfring
2015-01-31 22:51 ` Lino Sanfilippo
2015-01-31 17:50 ` Lino Sanfilippo
2015-01-31 21:52 ` SF Markus Elfring
2015-01-31 22:09 ` Lino Sanfilippo
2015-02-04 0:10 ` David Miller
2015-02-04 9:54 ` SF Markus Elfring
2015-01-31 17:15 ` [PATCH] net: sctp: Deletion of an unnecessary check before the function call "kfree" SF Markus Elfring
2015-01-31 18:38 ` Neil Horman
2015-02-03 3:30 ` David Miller
2015-01-31 21:14 ` [PATCH 0/3] netlabel: Deletion of a few unnecessary checks SF Markus Elfring
2015-01-31 21:34 ` [PATCH 1/3] netlabel: Deletion of an unnecessary check before the function call "cipso_v4_doi_putdef" SF Markus Elfring
2015-02-01 2:20 ` Paul Moore
2015-01-31 21:36 ` [PATCH 2/3] netlabel: Deletion of an unnecessary check before the function call "cipso_v4_doi_free" SF Markus Elfring
2015-02-01 2:22 ` Paul Moore
2015-01-31 21:38 ` [PATCH 3/3] netlabel: Less function calls in netlbl_mgmt_add_common() after error detection SF Markus Elfring
2015-02-01 2:40 ` Paul Moore
2015-02-01 10:15 ` [PATCH v2 " SF Markus Elfring
2015-02-01 14:39 ` Paul Moore
2015-02-01 20:30 ` David Miller
2015-02-02 10:22 ` [PATCH v3 0/3] netlabel: Deletion of a few unnecessary checks SF Markus Elfring
2015-02-02 10:25 ` [PATCH v3 1/3] netlabel: Deletion of an unnecessary check before the function call "cipso_v4_doi_putdef" SF Markus Elfring
2015-02-02 10:26 ` [PATCH v3 2/3] netlabel: Deletion of an unnecessary check before the function call "cipso_v4_doi_free" SF Markus Elfring
2015-02-02 11:06 ` SF Markus Elfring [this message]
2015-02-03 18:51 ` [PATCH] IBM-EMAC: Delete an unnecessary check before the function call "of_dev_put" SF Markus Elfring
2015-02-05 4:29 ` David Miller
2015-02-03 19:22 ` [PATCH] NetCP: Deletion of unnecessary checks before two function calls SF Markus Elfring
2015-02-05 4:30 ` David Miller
2015-02-05 12:01 ` Dan Carpenter
2015-02-05 15:50 ` Kwok, WingMan
2015-02-04 10:38 ` [PATCH] cxgb4: Delete an unnecessary check before the function call "release_firmware" SF Markus Elfring
2015-02-05 8:07 ` David Miller
2015-02-04 11:36 ` [PATCH] myri10ge: Delete an unnecessary check before the function call "kfree" SF Markus Elfring
2015-02-05 8:25 ` David Miller
2015-02-04 12:00 ` [PATCH] net: fec: Delete unnecessary checks " SF Markus Elfring
2015-02-05 8:26 ` David Miller
2015-02-04 12:21 ` [PATCH] netxen: Delete an unnecessary check " SF Markus Elfring
2015-02-05 8:26 ` David Miller
2015-02-04 13:13 ` [PATCH] qlogic: Deletion of unnecessary checks before two function calls SF Markus Elfring
2015-02-05 8:33 ` David Miller
2015-02-04 15:00 ` [PATCH] net: ep93xx_eth: Delete unnecessary checks before the function call "kfree" SF Markus Elfring
2015-02-04 15:59 ` Hartley Sweeten
2015-02-05 8:37 ` David Miller
2015-02-04 16:45 ` [PATCH 0/2] CW1200: Deletion of an unnecessary check SF Markus Elfring
2015-02-04 16:47 ` [PATCH 1/2] CW1200: Delete an unnecessary check before the function call "release_firmware" SF Markus Elfring
2015-02-06 6:49 ` [1/2] cw1200: " Kalle Valo
2015-02-04 16:48 ` [PATCH 2/2] CW1200: Less function calls in cw1200_load_firmware_cw1200() after error detection SF Markus Elfring
2015-02-04 17:54 ` [PATCH] ath9k: Delete an unnecessary check before the function call "relay_close" SF Markus Elfring
2015-02-06 6:50 ` ath9k: Delete an unnecessary check before the function call"relay_close" Kalle Valo
2015-02-04 18:33 ` [PATCH] ath10k: Delete unnecessary checks before the function call "release_firmware" SF Markus Elfring
2015-03-04 12:06 ` Kalle Valo
2015-02-04 18:56 ` [PATCH] orinoco: Delete an unnecessary check before the function call "kfree" SF Markus Elfring
2015-02-06 6:51 ` Kalle Valo
2015-02-04 19:10 ` [PATCH] HostAP: " SF Markus Elfring
2015-02-06 6:52 ` hostap: " Kalle Valo
2015-02-04 19:40 ` [PATCH] net: brcm80211: Delete unnecessary checks before two function calls SF Markus Elfring
2015-02-06 6:53 ` Kalle Valo
2015-06-29 10:48 ` [PATCH] net-Liquidio: Delete unnecessary checks before the function call "vfree" SF Markus Elfring
2015-06-29 16:28 ` David Miller
2015-07-02 14:43 ` [PATCH] net-ipv6: Delete an unnecessary check before the function call "free_percpu" SF Markus Elfring
2015-07-03 16:28 ` David Miller
2015-07-02 16:08 ` [PATCH] net-RDS: Delete an unnecessary check before the function call "module_put" SF Markus Elfring
2015-07-03 16:28 ` David Miller
2015-07-02 16:45 ` [PATCH] netlink: " SF Markus Elfring
2015-07-03 16:28 ` David Miller
2015-11-03 17:30 ` [PATCH] irda: Delete an unnecessary check before the function call "irlmp_unregister_service" SF Markus Elfring
2015-11-03 18:31 ` David Miller
2015-11-03 20:45 ` [PATCH 0/3] batman-adv: Deletion of a few unnecessary checks SF Markus Elfring
2015-11-03 20:52 ` [PATCH 1/3] batman-adv: Delete an unnecessary check before the function call "batadv_softif_vlan_free_ref" SF Markus Elfring
2015-11-21 21:48 ` [B.A.T.M.A.N.] " Marek Lindner
2015-11-03 20:54 ` [PATCH 2/3] batman-adv: Split a condition check SF Markus Elfring
2015-11-21 21:51 ` [B.A.T.M.A.N.] " Marek Lindner
2015-11-03 20:56 ` [PATCH 3/3] batman-adv: Less function calls in batadv_is_ap_isolated() after error detection SF Markus Elfring
2015-11-20 8:47 ` [B.A.T.M.A.N.] " Antonio Quartulli
[not found] ` <564EDE1D.7070809@meshcoding.com>
[not found] ` <564EDE1D.7070809-x4xJYDvStAgysxA8WJXlww@public.gmane.org>
2015-11-20 10:56 ` SF Markus Elfring
[not found] ` <1655341.WCvHHx7pqD@bentobox>
2016-03-11 12:40 ` [PATCH] " SF Markus Elfring
2016-03-14 19:25 ` David Miller
2016-03-15 0:14 ` Antonio Quartulli
2015-11-06 7:15 ` [PATCH] DWC Ethernet QoS: Delete an unnecessary check before the function call "of_node_put" SF Markus Elfring
2015-11-07 4:33 ` David Miller
2015-11-07 14:15 ` [PATCH] ethernet-synopsys: Delete an unnecessary check before of_node_put() SF Markus Elfring
2015-11-07 14:50 ` David Miller
2015-11-07 15:34 ` [PATCH] dwc_eth_qos: Delete an unnecessary check before the function call "of_node_put" SF Markus Elfring
2015-11-07 18:19 ` David Miller
2015-11-06 8:39 ` [PATCH] fjes: Delete an unnecessary check before the function call "vfree" SF Markus Elfring
2015-11-07 18:18 ` David Miller
2015-11-14 17:12 ` [PATCH] net: dsa: Delete an unnecessary check before the function call "put_device" SF Markus Elfring
2015-11-16 20:11 ` David Miller
2015-11-14 19:05 ` [PATCH] net-ipv6: Delete unnecessary checks before the function call "kfree_skb" SF Markus Elfring
2015-11-15 3:32 ` Eric Dumazet
2015-11-15 6:17 ` SF Markus Elfring
2015-11-14 19:27 ` [PATCH] mac802154: Delete an unnecessary check " SF Markus Elfring
2015-11-15 0:20 ` Marcel Holtmann
2015-11-14 21:10 ` [PATCH] Bluetooth-cmtp: " SF Markus Elfring
[not found] ` <5647A33E.3030103-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
2015-11-15 0:21 ` Marcel Holtmann
2015-11-14 21:28 ` [PATCH] net-hsr: Delete unnecessary checks " SF Markus Elfring
2015-11-24 13:42 ` Arvid Brodin
2015-11-14 21:50 ` [PATCH] NFC-nci: " SF Markus Elfring
2015-11-16 9:43 ` [PATCH 0/2] mISDN: Deletion of an unnecessary check SF Markus Elfring
2015-11-16 9:45 ` [PATCH 1/2] mISDN: Delete an unnecessary check before the function call "kfree_skb" SF Markus Elfring
2015-11-16 9:47 ` [PATCH 2/2] mISDN: One function call less in mISDN_sock_sendmsg() after error detection SF Markus Elfring
2015-11-16 10:22 ` [PATCH] WiMAX-i2400m: Delete an unnecessary check before the function call "kfree_skb" SF Markus Elfring
2016-07-19 20:11 ` SF Markus Elfring
2015-11-16 11:28 ` [PATCH] ixp4xx_eth: Delete an unnecessary check before the function call "dma_pool_destroy" SF Markus Elfring
2015-11-25 12:19 ` Krzysztof Hałasa
2015-11-16 11:52 ` [PATCH] cxgb3: Delete unnecessary checks before the function call "kfree_skb" SF Markus Elfring
2015-11-16 12:18 ` [PATCH] rtlwifi: " SF Markus Elfring
2015-11-26 13:01 ` rtlwifi: Delete unnecessary checks before the function call"kfree_skb" Kalle Valo
2015-11-16 12:36 ` [PATCH] ixp4xx_hss: Delete an unnecessary check before the function call "dma_pool_destroy" SF Markus Elfring
2015-11-25 12:19 ` Krzysztof Hałasa
2015-11-16 12:57 ` [PATCH] ieee802154-atusb: Delete an unnecessary check before the function call "kfree_skb" SF Markus Elfring
2015-11-16 13:46 ` Stefan Schmidt
2015-11-17 14:01 ` Marcel Holtmann
2015-11-17 16:19 ` Stefan Schmidt
2015-11-17 16:17 ` Stefan Schmidt
2015-11-17 16:18 ` Stefan Schmidt
2015-12-10 10:14 ` Stefan Schmidt
2015-12-10 18:16 ` Marcel Holtmann
2015-12-10 22:45 ` Stefan Schmidt
2015-12-11 13:07 ` SF Markus Elfring
2015-12-11 13:21 ` Stefan Schmidt
2015-11-17 16:43 ` [PATCH] net-scm: Delete an unnecessary check before the function call "kfree" SF Markus Elfring
2015-11-17 17:10 ` David Miller
2015-11-17 17:13 ` Daniel Borkmann
2015-11-17 18:05 ` SF Markus Elfring
2015-11-17 18:37 ` Daniel Borkmann
2015-11-18 7:45 ` net-scm: Macro for special pattern? SF Markus Elfring
2015-11-18 12:43 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54CF5A3F.6080600@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=davem@davemloft.net \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paul@paul-moore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).