netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH RESEND][next] bnxt_en: Fix fall-through warnings for Clang
@ 2021-03-05  9:50 Gustavo A. R. Silva
  2021-04-20 20:27 ` Gustavo A. R. Silva
  0 siblings, 1 reply; 3+ messages in thread
From: Gustavo A. R. Silva @ 2021-03-05  9:50 UTC (permalink / raw)
  To: Michael Chan, David S. Miller, Jakub Kicinski
  Cc: netdev, linux-kernel, Gustavo A. R. Silva, linux-hardening

In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
by explicitly adding a break statement instead of just letting the code
fall through to the next case.

Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
 drivers/net/ethernet/broadcom/bnxt/bnxt.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index b53a0d87371a..a34810750058 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -2158,6 +2158,7 @@ static int bnxt_hwrm_handler(struct bnxt *bp, struct tx_cmp *txcmp)
 	case CMPL_BASE_TYPE_HWRM_ASYNC_EVENT:
 		bnxt_async_event_process(bp,
 					 (struct hwrm_async_event_cmpl *)txcmp);
+		break;
 
 	default:
 		break;
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH RESEND][next] bnxt_en: Fix fall-through warnings for Clang
  2021-03-05  9:50 [PATCH RESEND][next] bnxt_en: Fix fall-through warnings for Clang Gustavo A. R. Silva
@ 2021-04-20 20:27 ` Gustavo A. R. Silva
  2021-05-18  0:23   ` Gustavo A. R. Silva
  0 siblings, 1 reply; 3+ messages in thread
From: Gustavo A. R. Silva @ 2021-04-20 20:27 UTC (permalink / raw)
  To: Gustavo A. R. Silva, Michael Chan, David S. Miller, Jakub Kicinski
  Cc: netdev, linux-kernel, linux-hardening

Hi all,

Friendly ping: who can take this, please?

Thanks
--
Gustavo

On 3/5/21 03:50, Gustavo A. R. Silva wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
> by explicitly adding a break statement instead of just letting the code
> fall through to the next case.
> 
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> ---
>  drivers/net/ethernet/broadcom/bnxt/bnxt.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> index b53a0d87371a..a34810750058 100644
> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> @@ -2158,6 +2158,7 @@ static int bnxt_hwrm_handler(struct bnxt *bp, struct tx_cmp *txcmp)
>  	case CMPL_BASE_TYPE_HWRM_ASYNC_EVENT:
>  		bnxt_async_event_process(bp,
>  					 (struct hwrm_async_event_cmpl *)txcmp);
> +		break;
>  
>  	default:
>  		break;
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH RESEND][next] bnxt_en: Fix fall-through warnings for Clang
  2021-04-20 20:27 ` Gustavo A. R. Silva
@ 2021-05-18  0:23   ` Gustavo A. R. Silva
  0 siblings, 0 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2021-05-18  0:23 UTC (permalink / raw)
  To: Gustavo A. R. Silva, Michael Chan, David S. Miller, Jakub Kicinski
  Cc: netdev, linux-kernel, linux-hardening

Hi,

I'm taking this in my -next[1] branch for v5.14.

Thanks
--
Gustavo

[1] https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git/log/?h=for-next/kspp

On 4/20/21 15:27, Gustavo A. R. Silva wrote:
> Hi all,
> 
> Friendly ping: who can take this, please?
> 
> Thanks
> --
> Gustavo
> 
> On 3/5/21 03:50, Gustavo A. R. Silva wrote:
>> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
>> by explicitly adding a break statement instead of just letting the code
>> fall through to the next case.
>>
>> Link: https://github.com/KSPP/linux/issues/115
>> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
>> ---
>>  drivers/net/ethernet/broadcom/bnxt/bnxt.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
>> index b53a0d87371a..a34810750058 100644
>> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
>> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
>> @@ -2158,6 +2158,7 @@ static int bnxt_hwrm_handler(struct bnxt *bp, struct tx_cmp *txcmp)
>>  	case CMPL_BASE_TYPE_HWRM_ASYNC_EVENT:
>>  		bnxt_async_event_process(bp,
>>  					 (struct hwrm_async_event_cmpl *)txcmp);
>> +		break;
>>  
>>  	default:
>>  		break;
>>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-05-18  0:23 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-05  9:50 [PATCH RESEND][next] bnxt_en: Fix fall-through warnings for Clang Gustavo A. R. Silva
2021-04-20 20:27 ` Gustavo A. R. Silva
2021-05-18  0:23   ` Gustavo A. R. Silva

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).