From: Daniel Borkmann <daniel@iogearbox.net>
To: Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>,
Eric Dumazet <eric.dumazet@gmail.com>,
Yuchung Cheng <ycheng@google.com>,
Neal Cardwell <ncardwell@google.com>
Subject: Re: [PATCH net-next 1/2] tcp: prepare CC get_info() access from getsockopt()
Date: Wed, 29 Apr 2015 09:55:16 +0200 [thread overview]
Message-ID: <55408E64.1050306@iogearbox.net> (raw)
In-Reply-To: <1430263429-4069-2-git-send-email-edumazet@google.com>
On 04/29/2015 01:23 AM, Eric Dumazet wrote:
> We would like that optional info provided by Congestion Control
> modules using netlink can also be read using getsockopt()
>
> This patch changes get_info() to put this information in a buffer,
> instead of skb, like tcp_get_info(), so that following patch
> can reuse this common infrastructure.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Yuchung Cheng <ycheng@google.com>
> Cc: Neal Cardwell <ncardwell@google.com>
Looks good to me, thanks!
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
next prev parent reply other threads:[~2015-04-29 7:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-28 23:23 [PATCH net-next 0/2] tcp: extend access to CC information Eric Dumazet
2015-04-28 23:23 ` [PATCH net-next 1/2] tcp: prepare CC get_info() access from getsockopt() Eric Dumazet
2015-04-29 0:58 ` Neal Cardwell
2015-04-29 7:55 ` Daniel Borkmann [this message]
2015-04-29 16:10 ` Yuchung Cheng
2015-04-29 22:12 ` David Miller
2015-04-29 22:40 ` Eric Dumazet
2015-04-29 23:20 ` [PATCH net-next] tcp_westwood: fix tcp_westwood_info() Eric Dumazet
2015-04-29 23:36 ` Neal Cardwell
2015-04-30 4:28 ` David Miller
2015-04-28 23:23 ` [PATCH net-next 2/2] tcp: add TCP_CC_INFO socket option Eric Dumazet
2015-04-29 1:00 ` Neal Cardwell
2015-04-29 8:17 ` Daniel Borkmann
2015-04-29 11:07 ` Eric Dumazet
2015-04-29 11:15 ` Daniel Borkmann
2015-04-29 16:15 ` Yuchung Cheng
2015-04-29 22:12 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55408E64.1050306@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).