From mboxrd@z Thu Jan 1 00:00:00 1970 From: roopa Subject: Re: [PATCH net-next v6 14/23] bridge: restore br_setlink back to original Date: Sun, 10 May 2015 09:10:40 -0700 Message-ID: <554F8300.5070709@cumulusnetworks.com> References: <1431193225-807-1-git-send-email-sfeldma@gmail.com> <1431193225-807-15-git-send-email-sfeldma@gmail.com> <20150509190031.GG2290@nanopsycho> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: sfeldma@gmail.com, netdev@vger.kernel.org, linux@roeck-us.net, f.fainelli@gmail.com, andrew@lunn.ch, simon.horman@netronome.com, joe@perches.com, sridhar.samudrala@intel.com, ronen.arad@intel.com To: Jiri Pirko Return-path: Received: from mail-pd0-f175.google.com ([209.85.192.175]:33567 "EHLO mail-pd0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751405AbbEJQKn (ORCPT ); Sun, 10 May 2015 12:10:43 -0400 Received: by pdbnk13 with SMTP id nk13so127390431pdb.0 for ; Sun, 10 May 2015 09:10:42 -0700 (PDT) In-Reply-To: <20150509190031.GG2290@nanopsycho> Sender: netdev-owner@vger.kernel.org List-ID: On 5/9/15, 12:00 PM, Jiri Pirko wrote: > Sat, May 09, 2015 at 07:40:16PM CEST, sfeldma@gmail.com wrote: >> From: Scott Feldman >> >> Restore br_setlink back to original and don't call into SELF port driver. >> rtnetlink.c:bridge_setlink() already does a call into port driver for SELF. >> >> bridge set link cmd defaults to MASTER. From man page for bridge link set >> cmd: >> >> self link setting is configured on specified physical device >> >> master link setting is configured on the software bridge (default) >> >> The link setting has two values: the device-side value and the software >> bridge-side value. These are independent and settable using the bridge >> link set cmd by specifying some combination of [master] | [self]. >> Futhermore, the device-side and bridge-side settings have their own initial >> value, viewable from bridge -d link show cmd. >> >> Restoring br_setlink back to original makes rocker (the only in-kernel user >> of SELF link settings) work as first implement: two-sided values. >> >> It's true that when both MASTER and SELF are specified from the command, >> two netlink notifications are generated, one for each side of the settings. >> The user-space app can distiquish between the two notifications by >> observing the MASTER or SELF flag. > This is revert of: > > commit 68e331c785b85b78f4155e2ab6f90e976b609dc1 > Author: Roopa Prabhu > Date: Thu Jan 29 22:40:14 2015 -0800 > > bridge: offload bridge port attributes to switch asic if feature flag set > > Noting that because I want to make sure everybody is ok with new > behaviour. I tend to like it more. > I am not ok with it. I have raised this earlier. same argument as the fib code, app now has to remember to call with both master and self. I do however feel that this code needs some rework..,.add to hardware first and then software just like fib and rollback hardware on failure. In which case, i am ok with submitting a new patch to do it differently. thanks, Roopa