From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jamal Hadi Salim Subject: Re: [patch net-next 15/15] tc: introduce Flower classifier Date: Mon, 11 May 2015 08:08:34 -0400 Message-ID: <55509BC2.2090702@mojatatu.com> References: <1431177038-11555-1-git-send-email-jiri@resnulli.us> <1431177038-11555-16-git-send-email-jiri@resnulli.us> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, tgraf@suug.ch, jesse@nicira.com, kaber@trash.net, therbert@google.com, edumazet@google.com, alexander.h.duyck@redhat.com, hannes@stressinduktion.org, ast@plumgrid.com, daniel@iogearbox.net, herbert@gondor.apana.org.au, cwang@twopensource.com, john.fastabend@gmail.com To: Jiri Pirko , netdev@vger.kernel.org Return-path: Received: from mail-ig0-f178.google.com ([209.85.213.178]:32832 "EHLO mail-ig0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751300AbbEKMIi (ORCPT ); Mon, 11 May 2015 08:08:38 -0400 Received: by igbpi8 with SMTP id pi8so70642361igb.0 for ; Mon, 11 May 2015 05:08:37 -0700 (PDT) In-Reply-To: <1431177038-11555-16-git-send-email-jiri@resnulli.us> Sender: netdev-owner@vger.kernel.org List-ID: On 05/09/15 09:10, Jiri Pirko wrote: > This patch introduces a flow-based filter. So far, the very essential > packet fields are supported. > > This patch is only the first step. There is a lot of potential performance > improvements possible to implement. Also a lot of features are missing > now. They will be addressed in follow-up patches. > > Signed-off-by: Jiri Pirko I have a question Jiri: What kind of flower is this? ;-> Very nice - Glad Dave pushed you to go this direction. For a usable classifier that performs reasonably well, i think this one is going to look good. My suggestion is to not add TCA_FLOWER_POLICE attribute. Policers can be added via TCA_FLOWER_ACT (which is the modern way to do it). Infact i would suggest even in your iproute2 code, please kill the conditional that tries to parse for TCA_FLOWER_POLICE Other than that: Acked-by: Jamal Hadi Salim cheers, jamal