From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Duyck Subject: Re: [patch net-next 06/15] net: move __skb_tx_hash to skbuff.c Date: Mon, 11 May 2015 08:55:11 -0700 Message-ID: <5550D0DF.7090806@redhat.com> References: <1431177038-11555-1-git-send-email-jiri@resnulli.us> <1431177038-11555-7-git-send-email-jiri@resnulli.us> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, jhs@mojatatu.com, tgraf@suug.ch, jesse@nicira.com, kaber@trash.net, therbert@google.com, edumazet@google.com, hannes@stressinduktion.org, ast@plumgrid.com, daniel@iogearbox.net, herbert@gondor.apana.org.au, cwang@twopensource.com, john.fastabend@gmail.com To: Jiri Pirko , netdev@vger.kernel.org Return-path: Received: from mx1.redhat.com ([209.132.183.28]:57783 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932300AbbEKPzP (ORCPT ); Mon, 11 May 2015 11:55:15 -0400 In-Reply-To: <1431177038-11555-7-git-send-email-jiri@resnulli.us> Sender: netdev-owner@vger.kernel.org List-ID: On 05/09/2015 06:10 AM, Jiri Pirko wrote: > __skb_tx_hash function has no relation to flow_dissect so just muve it > to skbuff.c (it is declared in skbuff.h) > > Signed-off-by: Jiri Pirko Minor nit, move is spelled with an o, not a u. Also any reason for moving this to skbuff.c instead of dev.c? It seems like this might be better placed there since the only caller is in netdevice.h. - Alex