From: Mugunthan V N <mugunthanvnm@ti.com>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: <netdev@vger.kernel.org>, <davem@davemloft.net>
Subject: Re: [net-next PATCH 2/2] drivers: net: cpsw: add separate napi for tx packet handling for performance improvment
Date: Tue, 28 Jul 2015 11:32:43 +0530 [thread overview]
Message-ID: <55B71B03.5030002@ti.com> (raw)
In-Reply-To: <20150727212206.GA8912@electric-eye.fr.zoreil.com>
On Tuesday 28 July 2015 02:52 AM, Francois Romieu wrote:
> Mugunthan V N <mugunthanvnm@ti.com> :
> [...]
>> diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
>> index d68d759..4f98537 100644
>> --- a/drivers/net/ethernet/ti/cpsw.c
>> +++ b/drivers/net/ethernet/ti/cpsw.c
>> @@ -752,13 +753,22 @@ static irqreturn_t cpsw_tx_interrupt(int irq, void *dev_id)
>> struct cpsw_priv *priv = dev_id;
>>
>> cpdma_ctlr_eoi(priv->dma, CPDMA_EOI_TX);
>> - cpdma_chan_process(priv->txch, 128);
>> + writel(0, &priv->wr_regs->tx_en);
>> +
>> + if (netif_running(priv->ndev)) {
>> + napi_schedule(&priv->napi_tx);
>> + return IRQ_HANDLED;
>> + }
>
>
> cpsw_ndo_stop calls napi_disable: you can remove netif_running.
>
Hmmmm, Will fix in v2.
Regards
Mugunthan V N
next prev parent reply other threads:[~2015-07-28 6:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-27 11:18 [net-next PATCH 0/2] CPSW interrupt handling cleanup and performance improvement Mugunthan V N
2015-07-27 11:19 ` [net-next PATCH 1/2] drivers: net: cpsw: remove disable_irq/enable_irq as irq can be masked from cpsw itself Mugunthan V N
2015-07-27 11:19 ` [net-next PATCH 2/2] drivers: net: cpsw: add separate napi for tx packet handling for performance improvment Mugunthan V N
2015-07-27 21:22 ` Francois Romieu
2015-07-28 6:02 ` Mugunthan V N [this message]
2015-07-28 6:18 ` Mugunthan V N
2015-07-28 22:30 ` Francois Romieu
2015-07-29 5:18 ` Mugunthan V N
2015-07-29 22:57 ` Francois Romieu
2015-07-30 6:12 ` Mugunthan V N
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B71B03.5030002@ti.com \
--to=mugunthanvnm@ti.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).