netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jamal Hadi Salim <jhs@mojatatu.com>
To: David Miller <davem@davemloft.net>, xiyou.wangcong@gmail.com
Cc: netdev@vger.kernel.org, stephen@networkplumber.org
Subject: Re: [Patch net-next 4/5] net_sched: forbid setting default qdisc to inappropriate ones
Date: Fri, 28 Aug 2015 08:26:53 -0400	[thread overview]
Message-ID: <55E0538D.80502@mojatatu.com> (raw)
In-Reply-To: <20150827.212359.1624170801280596846.davem@davemloft.net>

On 08/28/15 00:23, David Miller wrote:

> If a default qdisc like HTB is choosen, we invoke the ->init() function
> and we change the HTB ->init() function to do something reasonable
> if a NULL set of configuration attributes is given.  ie. make HTB use
> some defaults.
>

That may work. Or to reduce ambiguity introduce qdisc->set_default().

cheers,
jamal

  reply	other threads:[~2015-08-28 12:26 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-26 22:41 [Patch net-next 0/5] net_sched: introduce static flags for qdisc's Cong Wang
2015-08-26 22:41 ` [Patch net-next 1/5] net_sched: move some qdisc flag into qdisc ops Cong Wang
2015-08-26 22:41 ` [Patch net-next 2/5] net_sched: move TCQ_F_MQROOT " Cong Wang
2015-08-26 22:41 ` [Patch net-next 3/5] net_sched: use a flag to indicate fifo qdiscs instead of the name Cong Wang
2015-08-26 22:41 ` [Patch net-next 4/5] net_sched: forbid setting default qdisc to inappropriate ones Cong Wang
2015-08-27  0:08   ` Stephen Hemminger
2015-08-27  0:14     ` Cong Wang
2015-08-27 22:30   ` David Miller
2015-08-27 22:39     ` Cong Wang
2015-08-27 22:42       ` David Miller
2015-08-27 22:47         ` Cong Wang
2015-08-27 23:18           ` David Miller
2015-08-28  1:49             ` Cong Wang
2015-08-28  4:23               ` David Miller
2015-08-28 12:26                 ` Jamal Hadi Salim [this message]
2015-08-28 21:39                 ` Cong Wang
2015-08-28 23:20                   ` David Miller
2015-08-30 19:07                     ` Jamal Hadi Salim
2015-09-02  6:05                       ` Cong Wang
2015-09-02  6:19                         ` David Miller
2015-09-02  6:26                           ` Cong Wang
2015-08-26 22:41 ` [Patch net-next 5/5] net_sched: move ingress flag into qdisc ops Cong Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55E0538D.80502@mojatatu.com \
    --to=jhs@mojatatu.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).