From: David Ahern <dsa@cumulusnetworks.com>
To: David Miller <davem@davemloft.net>, tgraf@suug.ch
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next 3/3] net: Add table id from route lookup to route response
Date: Wed, 2 Sep 2015 12:51:50 -0600 [thread overview]
Message-ID: <55E74546.4070501@cumulusnetworks.com> (raw)
In-Reply-To: <20150902.114914.1705777375118723461.davem@davemloft.net>
On 9/2/15 12:49 PM, David Miller wrote:
> From: Thomas Graf <tgraf@suug.ch>
> Date: Wed, 2 Sep 2015 20:43:46 +0200
>
>> On 09/02/15 at 09:40am, David Ahern wrote:
>>> rt_fill_info which is called for 'route get' requests hardcodes the
>>> table id as RT_TABLE_MAIN which is not correct when multiple tables
>>> are used. Use the newly added table id in the rtable to send back
>>> the correct table.
>>>
>>> Signed-off-by: David Ahern <dsa@cumulusnetworks.com>
>>
>> What RTM_GETROUTE returns is not the actual route but a description
>> of the routing decision which is why table id, scope, protocol, and
>> prefix length are hardcoded. This is indicated by the RTM_F_CLONED
>> flag. What you propose would break userspace ABI.
>
> Agreed, I don't think we can do this.
>
Doesn't the table used to come up with the decision matter for IPv4?
ie., hardcoding to MAIN is misleading when there is absolutely no way
the decision comes from that table. IPv6 already returns the table id.
Or is your response that it breaks ABI and hence not going to fix.
next prev parent reply other threads:[~2015-09-02 18:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-02 16:40 [PATCH net-next 1/3] net: Refactor rtable initialization David Ahern
2015-09-02 16:40 ` [PATCH net-next 2/3] net: Add FIB table id to rtable David Ahern
2015-09-02 16:40 ` [PATCH net-next 3/3] net: Add table id from route lookup to route response David Ahern
2015-09-02 18:43 ` Thomas Graf
2015-09-02 18:49 ` David Miller
2015-09-02 18:51 ` David Ahern [this message]
2015-09-02 19:08 ` Thomas Graf
2015-09-02 19:43 ` Andy Gospodarek
2015-09-02 20:18 ` Thomas Graf
2015-09-02 22:33 ` David Miller
2015-09-02 20:16 ` [PATCH net-next v2] " David Ahern
2015-09-02 20:23 ` Thomas Graf
2015-09-02 20:34 ` David Ahern
2015-09-02 20:41 ` Alexander Duyck
2015-09-02 20:47 ` David Ahern
2015-09-02 20:53 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E74546.4070501@cumulusnetworks.com \
--to=dsa@cumulusnetworks.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).