From: Alexander Duyck <alexander.duyck@gmail.com>
To: Hannes Frederic Sowa <hannes@stressinduktion.org>,
Jay Vosburgh <jay.vosburgh@canonical.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] ipv6: recreate ipv6 link-local addresses when increasing MTU over IPV6_MIN_MTU
Date: Mon, 26 Oct 2015 13:52:29 -0700 [thread overview]
Message-ID: <562E928D.2010407@gmail.com> (raw)
In-Reply-To: <1445892312.1018239.420827817.3EC76081@webmail.messagingengine.com>
On 10/26/2015 01:45 PM, Hannes Frederic Sowa wrote:
> Hi,
>
> On Mon, Oct 26, 2015, at 20:16, Jay Vosburgh wrote:
>> Hannes Frederic Sowa <hannes@stressinduktion.org> wrote:
>>
>>> Hello Alex,
>>>
>>> On Mon, Oct 26, 2015, at 16:52, Alexander Duyck wrote:
>>>> Seems like this code isn't quite correct. You are calling ipv6_add_dev
>>>> for slave devices, and if I understand things correctly I don't believe
>>>> that was happening before and may be an unintended side effect.
>>> Ah, btw., autoconf and ipv6 operation on IFF_SLAVE devices is actually
>>> desired nowadays and don't think we can change this. See also:
>>> <https://patchwork.ozlabs.org/patch/531196/>
>> IPv6 addrconf on IFF_SLAVE devices was disabled for bonding
>> slaves in commit c2edacf80e15 because it caused issues with snooping
>> switches.
>>
>> This is also referenced in
>>
>> https://bugzilla.redhat.com/show_bug.cgi?id=236750
>>
>> Won't re-enabling autoconf on IFF_SLAVE devices cause that issue
>> to return?
> Both patches don't enable autoconf on IFF_SLAVE devices. Sorry for being
> imprecise. The referred patch was changing the behavior to whether the
> device had a master device.
Yes, the IFF_SLAVE comment on my part was an error in interpretation of
the code.
> @Alex, I will take your patch and submit it with the necessary guards to
> not enable ipv6 again if we forcefully disable ipv6 and later on shrink
> and increase the MTU again. I will do so in your name. Thanks again for
> the patch!
No problem. If you want to you can take over authorship of the patch
and just leave my signed-off-by on there. I'm good either way.
- Alex
next prev parent reply other threads:[~2015-10-26 20:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-26 14:36 [PATCH net-next] ipv6: recreate ipv6 link-local addresses when increasing MTU over IPV6_MIN_MTU Hannes Frederic Sowa
2015-10-26 15:52 ` Alexander Duyck
2015-10-26 16:05 ` Hannes Frederic Sowa
2015-10-26 17:07 ` Alexander Duyck
2015-10-26 17:21 ` Hannes Frederic Sowa
2015-10-26 19:05 ` Hannes Frederic Sowa
2015-10-26 16:33 ` Hannes Frederic Sowa
2015-10-26 19:16 ` Jay Vosburgh
2015-10-26 20:45 ` Hannes Frederic Sowa
2015-10-26 20:52 ` Alexander Duyck [this message]
2015-10-26 18:06 ` [net-next PATCH v2] " Alexander Duyck
2015-10-30 9:11 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562E928D.2010407@gmail.com \
--to=alexander.duyck@gmail.com \
--cc=hannes@stressinduktion.org \
--cc=jay.vosburgh@canonical.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).