From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: "John W. Linville" <linville@tuxdriver.com>, netdev@vger.kernel.org
Cc: "Dave Miller" <davem@davemloft.net>,
"Pravin B Shelar" <pshelar@nicira.com>,
"Jesse Gross" <jesse@nicira.com>, "Jiri Benc" <jbenc@redhat.com>,
"YOSHIFUJI Hideaki/吉藤英明" <hideaki.yoshifuji@miraclelinux.com>
Subject: Re: [PATCH v7 3/3] geneve: add IPv6 bits to geneve_fill_metadata_dst
Date: Tue, 27 Oct 2015 15:48:12 +0300 [thread overview]
Message-ID: <562F728C.6030201@cogentembedded.com> (raw)
In-Reply-To: <1445893306-31225-3-git-send-email-linville@tuxdriver.com>
Hello.
On 10/27/2015 12:01 AM, John W. Linville wrote:
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
> ---
> v7 -- initial version (numbered to match earlier patches in series)
>
> drivers/net/geneve.c | 28 +++++++++++++++++++++-------
> 1 file changed, 21 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c
> index 44e724508c55..be532d7b879d 100644
> --- a/drivers/net/geneve.c
> +++ b/drivers/net/geneve.c
> @@ -1006,16 +1006,30 @@ static int geneve_fill_metadata_dst(struct net_device *dev, struct sk_buff *skb)
> struct geneve_dev *geneve = netdev_priv(dev);
> struct rtable *rt;
> struct flowi4 fl4;
> +#if IS_ENABLED(CONFIG_IPV6)
> + struct dst_entry *dst;
> + struct flowi6 fl6;
> +#endif
>
> - if (ip_tunnel_info_af(info) != AF_INET)
> - return -EINVAL;
> + if (ip_tunnel_info_af(info) == AF_INET) {
> + rt = geneve_get_v4_rt(skb, dev, &fl4, info);
> + if (IS_ERR(rt))
> + return PTR_ERR(rt);
>
> - rt = geneve_get_v4_rt(skb, dev, &fl4, info);
> - if (IS_ERR(rt))
> - return PTR_ERR(rt);
> + ip_rt_put(rt);
> + info->key.u.ipv4.src = fl4.saddr;
> +#if IS_ENABLED(CONFIG_IPV6)
> + } else if (ip_tunnel_info_af(info) == AF_INET6) {
> + dst = geneve_get_v6_dst(skb, dev, &fl6, info);
> + if (IS_ERR(dst))
> + return PTR_ERR(dst);
> +
> + dst_release(dst);
> + info->key.u.ipv6.src = fl6.saddr;
> +#endif
> + } else
> + return -EINVAL;
You need {} on this branch too, according to Documentation/CodingStyle.
MBR, Sergei
next prev parent reply other threads:[~2015-10-27 12:48 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-24 18:34 [RFT] geneve: implement support for IPv6-based tunnels John W. Linville
2015-09-24 18:39 ` [PATCH iproute2] geneve: add support for IPv6 link partners John W. Linville
2015-11-24 0:23 ` Stephen Hemminger
2015-09-25 12:08 ` [RFT] geneve: implement support for IPv6-based tunnels Jiri Benc
2015-09-28 19:20 ` John W. Linville
2015-09-29 16:10 ` Jiri Benc
2015-09-30 17:04 ` [RFT v2] " John W. Linville
2015-09-30 18:07 ` kbuild test robot
2015-09-30 18:34 ` [RFT v3] " John W. Linville
2015-10-01 1:55 ` kbuild test robot
2015-10-01 15:38 ` Jiri Benc
2015-10-01 16:26 ` Jesse Gross
2015-10-01 20:03 ` John W. Linville
2015-10-01 21:07 ` Jesse Gross
2015-10-20 15:11 ` [PATCH v4 1/2] " John W. Linville
2015-10-20 15:11 ` [PATCH 2/2] geneve: handle ipv6 priority like ipv4 tos John W. Linville
2015-10-21 5:13 ` Jesse Gross
2015-10-20 22:55 ` [PATCH v4 1/2] geneve: implement support for IPv6-based tunnels kbuild test robot
2015-10-21 1:52 ` YOSHIFUJI Hideaki/吉藤英明
2015-10-21 18:58 ` John W. Linville
2015-10-21 5:06 ` Jesse Gross
2015-10-22 19:45 ` [PATCH v5 " John W. Linville
2015-10-22 19:45 ` [PATCH v5 2/2] geneve: handle ipv6 priority like ipv4 tos John W. Linville
2015-10-23 4:48 ` [PATCH v5 1/2] geneve: implement support for IPv6-based tunnels YOSHIFUJI Hideaki
2015-10-23 13:38 ` John W. Linville
2015-10-23 14:40 ` [PATCH v6 " John W. Linville
2015-10-23 14:40 ` [PATCH v6 2/2] geneve: handle ipv6 priority like ipv4 tos John W. Linville
2015-10-26 4:08 ` [PATCH v6 1/2] geneve: implement support for IPv6-based tunnels Jesse Gross
2015-10-26 21:01 ` [PATCH v7 1/3] " John W. Linville
2015-10-26 21:01 ` [PATCH v7 2/3] geneve: handle ipv6 priority like ipv4 tos John W. Linville
2015-10-30 3:11 ` David Miller
2015-10-26 21:01 ` [PATCH v7 3/3] geneve: add IPv6 bits to geneve_fill_metadata_dst John W. Linville
2015-10-27 12:48 ` Sergei Shtylyov [this message]
2015-10-27 13:49 ` [PATCH v8 " John W. Linville
2015-10-27 14:24 ` Jesse Gross
2015-10-30 3:12 ` David Miller
2015-10-30 3:11 ` [PATCH v7 1/3] geneve: implement support for IPv6-based tunnels David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562F728C.6030201@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=hideaki.yoshifuji@miraclelinux.com \
--cc=jbenc@redhat.com \
--cc=jesse@nicira.com \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).