From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarod Wilson Subject: Re: [PATCH net] net: fix feature changes on devices without ndo_set_features Date: Fri, 13 Nov 2015 09:34:28 -0500 Message-ID: <5645F4F4.1000307@redhat.com> References: <5645C0A5.2080506@cumulusnetworks.com> <1447422841-2333-1-git-send-email-razor@blackwall.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, davem@davemloft.net, Nikolay Aleksandrov , Jiri Pirko , Ido Schimmel , Sander Eikelenboom , Andy Gospodarek , Florian Fainelli To: Nikolay Aleksandrov Return-path: Received: from mx1.redhat.com ([209.132.183.28]:48939 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753799AbbKMOec (ORCPT ); Fri, 13 Nov 2015 09:34:32 -0500 In-Reply-To: <1447422841-2333-1-git-send-email-razor@blackwall.org> Sender: netdev-owner@vger.kernel.org List-ID: Nikolay Aleksandrov wrote: > From: Nikolay Aleksandrov > > When __netdev_update_features() was updated to ensure some features are > disabled on new lower devices, an error was introduced for devices which > don't have the ndo_set_features() method set. Before we'll just set the > new features, but now we return an error and don't set them. Fix this by > returning the old behaviour and setting err to 0 when ndo_set_features > is not present. > > Fixes: e7868a85e1b2 ("net/core: ensure features get disabled on new lower devs") > CC: Jarod Wilson > CC: Jiri Pirko > CC: Ido Schimmel > CC: Sander Eikelenboom > CC: Andy Gospodarek > CC: Florian Fainelli > Signed-off-by: Nikolay Aleksandrov > --- > Sander please feel free to give your Tested-by. Ah, good catch, thank you for cleaning up my mess. Reviewed-by: Jarod Wilson -- Jarod Wilson jarod@redhat.com