From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Subject: Re: net-scm: Delete an unnecessary check before the function call "kfree" Date: Tue, 17 Nov 2015 19:05:35 +0100 Message-ID: <564B6C6F.3070809@users.sourceforge.net> References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <564B5937.1070707@users.sourceforge.net> <564B602F.2020302@iogearbox.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Julia Lawall , eric.dumazet@gmail.com To: Daniel Borkmann , netdev@vger.kernel.org, "David S. Miller" Return-path: In-Reply-To: <564B602F.2020302@iogearbox.net> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org > Eric already mentioned that in some situations where it's critical, > it actually slows down the code, i.e. you'll have an extra > function call to get there and inside kfree() / kfree_skb() / etc, > the test is actually marked as unlikely(). How do you think about to add similar annotations to any more source code places? Regards, Markus