From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
netdev@vger.kernel.org
Cc: willemb@google.com, edumazet@google.com, dborkman@redhat.com,
davem@davemloft.net, mostrows@earthlink.net, nbd@openwrt.org
Subject: Re: [PATCH] packet: Allow packets with only a header (but no payload)
Date: Sun, 22 Nov 2015 00:32:12 +0300 [thread overview]
Message-ID: <5650E2DC.9060800@cogentembedded.com> (raw)
In-Reply-To: <1448067012-15090-1-git-send-email-martin.blumenstingl@googlemail.com>
Hello.
On 11/21/2015 3:50 AM, Martin Blumenstingl wrote:
> 9c70776 added validation for the packet size in packet_snd. This change
Please run your patch thru scripts/checkpatch.pl -- it now enforces
certain commit citing style.
> enforced that every packet needs a header with at least hard_header_len
> bytes and at least one byte payload.
>
> This fixes PPPoE connections which do not have a "Service" or
> "Host-Uniq" configured (which is violating the spec, but is still
> widely used in real-world setups). Those are currently failing with the
> following message: "pppd: packet size is too short (24 <= 24)"
>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
[...]
MBR, Sergei
next prev parent reply other threads:[~2015-11-21 21:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-21 16:14 [PATCH] packet: Allow packets with only a header (but no payload) Martin Blumenstingl
2015-07-21 16:28 ` Willem de Bruijn
2015-07-21 16:38 ` Martin Blumenstingl
2015-07-21 16:51 ` Willem de Bruijn
2015-07-27 22:35 ` Martin Blumenstingl
2015-07-29 6:05 ` Willem de Bruijn
2015-07-30 22:15 ` Martin Blumenstingl
2015-11-07 13:11 ` Felix Fietkau
2015-11-09 17:53 ` Willem de Bruijn
2015-11-09 19:02 ` Felix Fietkau
2015-11-21 0:50 ` Martin Blumenstingl
2015-11-21 21:32 ` Sergei Shtylyov [this message]
2015-11-22 16:46 ` [PATCH v3] " Martin Blumenstingl
2015-11-30 3:18 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5650E2DC.9060800@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=edumazet@google.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=mostrows@earthlink.net \
--cc=nbd@openwrt.org \
--cc=netdev@vger.kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).