From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Schmidt Subject: Re: [PATCH] ieee802154-atusb: Delete an unnecessary check before the function call "kfree_skb" Date: Thu, 10 Dec 2015 23:45:57 +0100 Message-ID: <566A00A5.8030806@osg.samsung.com> References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <564B5327.4010307@osg.samsung.com> <564B5344.1090200@osg.samsung.com> <56695093.8080605@osg.samsung.com> <7DCE62A2-DEA0-4ABF-A0D6-4EE00BDFFE95@holtmann.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: Alexander Aring , linux-wpan@vger.kernel.org, Network Development , LKML , kernel-janitors@vger.kernel.org, Julia Lawall To: Marcel Holtmann Return-path: In-Reply-To: <7DCE62A2-DEA0-4ABF-A0D6-4EE00BDFFE95@holtmann.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Hello. On 10/12/15 19:16, Marcel Holtmann wrote: > Hi Stefan, > >>>> From: Markus Elfring >>>> Date: Mon, 16 Nov 2015 13:50:23 +0100 >>>> >>>> The kfree_skb() function tests whether its argument is NULL and then >>>> returns immediately. Thus the test around the call is not needed. >>>> >>>> This issue was detected by using the Coccinelle software. >>>> >>>> Signed-off-by: Markus Elfring >>>> --- >>>> drivers/net/ieee802154/atusb.c | 3 +-- >>>> 1 file changed, 1 insertion(+), 2 deletions(-) >>>> >>>> diff --git a/drivers/net/ieee802154/atusb.c b/drivers/net/ieee802154/atusb.c >>>> index 199a94a..b1cd865 100644 >>>> --- a/drivers/net/ieee802154/atusb.c >>>> +++ b/drivers/net/ieee802154/atusb.c >>>> @@ -310,8 +310,7 @@ static void atusb_free_urbs(struct atusb *atusb) >>>> urb = usb_get_from_anchor(&atusb->idle_urbs); >>>> if (!urb) >>>> break; >>>> - if (urb->context) >>>> - kfree_skb(urb->context); >>>> + kfree_skb(urb->context); >>>> usb_free_urb(urb); >>>> } >>>> } >>> Acked-by: Stefan Schmidt >> >> You got the original patch and my ACK on this one or would you prefer me to resend it again? > this slipped through, but now it does no longer apply. > > Applying: ieee802154-atusb: Delete an unnecessary check before the function call "kfree_skb" > error: patch failed: drivers/net/ieee802154/atusb.c:310 > error: drivers/net/ieee802154/atusb.c: patch does not apply > Patch failed at 0001 ieee802154-atusb: Delete an unnecessary check before the function call "kfree_skb" Not good. I did another resend, this one applied, compiled and worked fine for me. You will be in the to line. regards Stefan Schmidt