netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nikolay Aleksandrov via Bridge <bridge@lists.linux-foundation.org>
To: Xin Long <lucien.xin@gmail.com>,
	network dev <netdev@vger.kernel.org>,
	bridge@lists.linux-foundation.org
Cc: davem@davemloft.net
Subject: Re: [PATCHv3 net-next 5/6] bridge: a netlink notification should be sent when those attributes are changed by br_sysfs_if
Date: Sat, 9 Apr 2016 14:45:24 +0200	[thread overview]
Message-ID: <5708F964.1090407@cumulusnetworks.com> (raw)
In-Reply-To: <8c87a70b3c214f90b7345edb68536429fdaad096.1460131308.git.lucien.xin@gmail.com>

On 04/08/2016 06:03 PM, Xin Long wrote:
> Now when we change the attributes of bridge or br_port by netlink,
> a relevant netlink notification will be sent, but if we change them
> by ioctl or sysfs, no notification will be sent.
> 
> We should ensure that whenever those attributes change internally or from
> sysfs/ioctl, that a netlink notification is sent out to listeners.
> 
> Also, NetworkManager will use this in the future to listen for out-of-band
> bridge master attribute updates and incorporate them into the runtime
> configuration.
> 
> This patch is used for br_sysfs_if, and we also move br_ifinfo_notify out
> of store_flag.
> 
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
> ---
>  net/bridge/br_sysfs_if.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 

Note: there's a slight behaviour change, before if the flags were the same
a notification wouldn't be sent, now it would. Anyway I don't see a problem
as this is true for other attributes which are set to the same value.

Reviewed-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>

  parent reply	other threads:[~2016-04-09 12:45 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-08 16:03 [PATCHv3 net-next 0/6] bridge: support sending rntl info when we set attributes through sysfs/ioctl Xin Long
2016-04-08 16:03 ` [PATCHv3 net-next 1/6] bridge: simplify the flush_store by calling store_bridge_parm Xin Long
2016-04-08 16:03   ` [PATCHv3 net-next 2/6] bridge: simplify the forward_delay_store " Xin Long
2016-04-08 16:03     ` [PATCHv3 net-next 3/6] bridge: simplify the stp_state_store " Xin Long
2016-04-08 16:03       ` [PATCHv3 net-next 4/6] bridge: a netlink notification should be sent when those attributes are changed by br_sysfs_br Xin Long
2016-04-08 16:03         ` [PATCHv3 net-next 5/6] bridge: a netlink notification should be sent when those attributes are changed by br_sysfs_if Xin Long
2016-04-08 16:03           ` [PATCHv3 net-next 6/6] bridge: a netlink notification should be sent when those attributes are changed by ioctl Xin Long
2016-04-09 12:49             ` Nikolay Aleksandrov via Bridge
2016-04-09 12:45           ` Nikolay Aleksandrov via Bridge [this message]
2016-04-09 12:41         ` [PATCHv3 net-next 4/6] bridge: a netlink notification should be sent when those attributes are changed by br_sysfs_br Nikolay Aleksandrov via Bridge
2016-04-09 12:33       ` [PATCHv3 net-next 3/6] bridge: simplify the stp_state_store by calling store_bridge_parm Nikolay Aleksandrov via Bridge
2016-04-09 12:31     ` [PATCHv3 net-next 2/6] bridge: simplify the forward_delay_store " Nikolay Aleksandrov via Bridge
2016-04-09 12:27   ` [PATCHv3 net-next 1/6] bridge: simplify the flush_store " Nikolay Aleksandrov via Bridge
2016-04-09 12:55 ` [PATCHv3 net-next 0/6] bridge: support sending rntl info when we set attributes through sysfs/ioctl Nikolay Aleksandrov via Bridge
2016-04-14  2:42 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5708F964.1090407@cumulusnetworks.com \
    --to=bridge@lists.linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=lucien.xin@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=nikolay@cumulusnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).