From: Alexei Starovoitov <ast@fb.com>
To: Eric Dumazet <edumazet@google.com>,
"David S . Miller" <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>,
Soheil Hassas Yeganeh <soheil@google.com>,
Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH v3 net-next 2/7] tcp: do not block bh during prequeue processing
Date: Fri, 29 Apr 2016 14:47:34 -0700 [thread overview]
Message-ID: <5723D676.30601@fb.com> (raw)
In-Reply-To: <1461964613-4872-3-git-send-email-edumazet@google.com>
On 4/29/16 2:16 PM, Eric Dumazet wrote:
> AFAIK, nothing in current TCP stack absolutely wants BH
> being disabled once socket is owned by a thread running in
> process context.
>
> As mentioned in my prior patch ("tcp: give prequeue mode some care"),
> processing a batch of packets might take time, better not block BH
> at all.
>
> Signed-off-by: Eric Dumazet<edumazet@google.com>
> Acked-by: Soheil Hassas Yeganeh<soheil@google.com>
Acked-by: Alexei Starovoitov <ast@kernel.org>
next prev parent reply other threads:[~2016-04-29 21:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-29 21:16 [PATCH v2 net-next 0/7] net: make TCP preemptible Eric Dumazet
2016-04-29 21:16 ` [PATCH v3 net-next 1/7] tcp: do not assume TCP code is non preemptible Eric Dumazet
2016-04-29 21:16 ` [PATCH v3 net-next 2/7] tcp: do not block bh during prequeue processing Eric Dumazet
2016-04-29 21:47 ` Alexei Starovoitov [this message]
2016-04-29 21:16 ` [PATCH v3 net-next 3/7] dccp: do not assume DCCP code is non preemptible Eric Dumazet
2016-04-29 21:16 ` [PATCH v3 net-next 4/7] udp: prepare for non BH masking at backlog processing Eric Dumazet
2016-04-29 21:16 ` [PATCH v3 net-next 5/7] sctp: prepare for socket backlog behavior change Eric Dumazet
2016-04-29 22:01 ` Marcelo Ricardo Leitner
2016-04-29 21:16 ` [PATCH v3 net-next 6/7] net: do not block BH while processing socket backlog Eric Dumazet
2016-04-29 21:47 ` Alexei Starovoitov
2016-04-29 21:16 ` [PATCH v3 net-next 7/7] tcp: make tcp_sendmsg() aware of " Eric Dumazet
2016-05-03 4:49 ` [PATCH net-next] tcp: guarantee forward progress in tcp_sendmsg() Eric Dumazet
2016-05-03 4:53 ` Soheil Hassas Yeganeh
2016-05-03 20:20 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5723D676.30601@fb.com \
--to=ast@fb.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=soheil@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).