From: David Ahern <dsahern@gmail.com>
To: Guillaume Nault <gnault@redhat.com>
Cc: netdev@vger.kernel.org, martin.varghese@nokia.com
Subject: Re: [PATCH iproute2-next 2/2] m_mpls: add mac_push action
Date: Sat, 17 Oct 2020 09:23:52 -0600 [thread overview]
Message-ID: <5804f20b-b8ea-9f02-7aac-129d35f46a2c@gmail.com> (raw)
In-Reply-To: <622d70e7bb6158c6f207661dea8c47e129f16107.1602598178.git.gnault@redhat.com>
On 10/13/20 8:32 AM, Guillaume Nault wrote:
> @@ -41,12 +44,12 @@ static void usage(void)
>
> static bool can_modify_mpls_fields(unsigned int action)
> {
> - return action == TCA_MPLS_ACT_PUSH || action == TCA_MPLS_ACT_MODIFY;
> + return action == TCA_MPLS_ACT_PUSH || action == TCA_MPLS_ACT_MAC_PUSH || action == TCA_MPLS_ACT_MODIFY;
> }
>
> -static bool can_modify_ethtype(unsigned int action)
> +static bool can_set_ethtype(unsigned int action)
> {
> - return action == TCA_MPLS_ACT_PUSH || action == TCA_MPLS_ACT_POP;
> + return action == TCA_MPLS_ACT_PUSH || action == TCA_MPLS_ACT_MAC_PUSH || action == TCA_MPLS_ACT_POP;
> }
>
> static bool is_valid_label(__u32 label)
nit: please wrap the lines with the new action.
Besides the nit, very nice and complete change set - man page, help, and
tests.
next prev parent reply other threads:[~2020-10-17 15:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 14:32 [PATCH iproute2-next 0/2] tc: support for new MPLS L2 VPN actions Guillaume Nault
2020-10-13 14:32 ` [PATCH iproute2-next 1/2] m_vlan: add pop_eth and push_eth actions Guillaume Nault
2020-10-13 14:32 ` [PATCH iproute2-next 2/2] m_mpls: add mac_push action Guillaume Nault
2020-10-17 15:23 ` David Ahern [this message]
2020-10-19 13:39 ` Guillaume Nault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5804f20b-b8ea-9f02-7aac-129d35f46a2c@gmail.com \
--to=dsahern@gmail.com \
--cc=gnault@redhat.com \
--cc=martin.varghese@nokia.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).