* [PATCH] net: ethernet: mediatek: ppe: fix wrong size passed to memset()
@ 2022-05-11 3:08 Yang Yingliang
2022-05-11 5:05 ` Felix Fietkau
2022-05-12 8:00 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Yang Yingliang @ 2022-05-11 3:08 UTC (permalink / raw)
To: linux-kernel, linux-mediatek, linux-arm-kernel, netdev; +Cc: nbd, davem, kuba
'foe_table' is a pointer, the real size of struct mtk_foe_entry
should be pass to memset().
Fixes: ba37b7caf1ed ("net: ethernet: mtk_eth_soc: add support for initializing the PPE")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/net/ethernet/mediatek/mtk_ppe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mediatek/mtk_ppe.c b/drivers/net/ethernet/mediatek/mtk_ppe.c
index 3ad10c793308..66298e2235c9 100644
--- a/drivers/net/ethernet/mediatek/mtk_ppe.c
+++ b/drivers/net/ethernet/mediatek/mtk_ppe.c
@@ -395,7 +395,7 @@ static void mtk_ppe_init_foe_table(struct mtk_ppe *ppe)
static const u8 skip[] = { 12, 25, 38, 51, 76, 89, 102 };
int i, k;
- memset(ppe->foe_table, 0, MTK_PPE_ENTRIES * sizeof(ppe->foe_table));
+ memset(ppe->foe_table, 0, MTK_PPE_ENTRIES * sizeof(*ppe->foe_table));
if (!IS_ENABLED(CONFIG_SOC_MT7621))
return;
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: ethernet: mediatek: ppe: fix wrong size passed to memset()
2022-05-11 3:08 [PATCH] net: ethernet: mediatek: ppe: fix wrong size passed to memset() Yang Yingliang
@ 2022-05-11 5:05 ` Felix Fietkau
2022-05-12 8:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Felix Fietkau @ 2022-05-11 5:05 UTC (permalink / raw)
To: Yang Yingliang, linux-kernel, linux-mediatek, linux-arm-kernel, netdev
Cc: davem, kuba
On 11.05.22 05:08, Yang Yingliang wrote:
> 'foe_table' is a pointer, the real size of struct mtk_foe_entry
> should be pass to memset().
>
> Fixes: ba37b7caf1ed ("net: ethernet: mtk_eth_soc: add support for initializing the PPE")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Acked-by: Felix Fietkau <nbd@nbd.name>
Thanks,
- Felix
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: ethernet: mediatek: ppe: fix wrong size passed to memset()
2022-05-11 3:08 [PATCH] net: ethernet: mediatek: ppe: fix wrong size passed to memset() Yang Yingliang
2022-05-11 5:05 ` Felix Fietkau
@ 2022-05-12 8:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-05-12 8:00 UTC (permalink / raw)
To: Yang Yingliang
Cc: linux-kernel, linux-mediatek, linux-arm-kernel, netdev, nbd, davem, kuba
Hello:
This patch was applied to netdev/net.git (master)
by Paolo Abeni <pabeni@redhat.com>:
On Wed, 11 May 2022 11:08:29 +0800 you wrote:
> 'foe_table' is a pointer, the real size of struct mtk_foe_entry
> should be pass to memset().
>
> Fixes: ba37b7caf1ed ("net: ethernet: mtk_eth_soc: add support for initializing the PPE")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> drivers/net/ethernet/mediatek/mtk_ppe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
- net: ethernet: mediatek: ppe: fix wrong size passed to memset()
https://git.kernel.org/netdev/net/c/00832b1d1a39
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-12 8:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-11 3:08 [PATCH] net: ethernet: mediatek: ppe: fix wrong size passed to memset() Yang Yingliang
2022-05-11 5:05 ` Felix Fietkau
2022-05-12 8:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).