From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Samudrala, Sridhar" Subject: Re: [PATCH 1/2 net-next] net_failover: fix net_failover_compute_features() Date: Thu, 31 May 2018 10:30:10 -0700 Message-ID: <5a8a67ee-a21b-2153-67cc-ca588ca2b253@intel.com> References: <20180531120124.pc4txiifxnrslbei@kili.mountain> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, Jiri Pirko , Jay Vosburgh To: Dan Carpenter , "David S. Miller" Return-path: Received: from mga12.intel.com ([192.55.52.136]:15281 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755737AbeEaRaL (ORCPT ); Thu, 31 May 2018 13:30:11 -0400 In-Reply-To: <20180531120124.pc4txiifxnrslbei@kili.mountain> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 5/31/2018 5:01 AM, Dan Carpenter wrote: > This has an '&' vs '|' typo so it starts with vlan_features set to none. > Also a u32 type isn't large enough to hold all the feature bits, it > should be netdev_features_t. > > Fixes: cfc80d9a1163 ("net: Introduce net_failover driver") > Signed-off-by: Dan Carpenter The patch looks correct, but this code is based on team/bonding drivers. So would like to get a confirmation from Jiri/Jay and if a similar fix is needed in those drivers too. > > diff --git a/drivers/net/net_failover.c b/drivers/net/net_failover.c > index 8b508e2cf29b..ef50158e90a9 100644 > --- a/drivers/net/net_failover.c > +++ b/drivers/net/net_failover.c > @@ -380,7 +380,8 @@ static rx_handler_result_t net_failover_handle_frame(struct sk_buff **pskb) > > static void net_failover_compute_features(struct net_device *dev) > { > - u32 vlan_features = FAILOVER_VLAN_FEATURES & NETIF_F_ALL_FOR_ALL; > + netdev_features_t vlan_features = FAILOVER_VLAN_FEATURES | > + NETIF_F_ALL_FOR_ALL; > netdev_features_t enc_features = FAILOVER_ENC_FEATURES; > unsigned short max_hard_header_len = ETH_HLEN; > unsigned int dst_release_flag = IFF_XMIT_DST_RELEASE |