From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DADBC282C4 for ; Tue, 12 Feb 2019 16:10:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7A66D217D9 for ; Tue, 12 Feb 2019 16:10:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730851AbfBLQKo (ORCPT ); Tue, 12 Feb 2019 11:10:44 -0500 Received: from www62.your-server.de ([213.133.104.62]:37998 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730461AbfBLQKo (ORCPT ); Tue, 12 Feb 2019 11:10:44 -0500 Received: from [78.46.172.2] (helo=sslproxy05.your-server.de) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1gtadu-0008SZ-GW; Tue, 12 Feb 2019 17:10:42 +0100 Received: from [178.197.248.36] (helo=localhost.localdomain) by sslproxy05.your-server.de with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1gtadu-0001MC-Ak; Tue, 12 Feb 2019 17:10:42 +0100 Subject: Re: [PATCH bpf-next] bpf: offload: add priv field for drivers To: Jakub Kicinski , alexei.starovoitov@gmail.com Cc: oss-drivers@netronome.com, netdev@vger.kernel.org References: <20190212082039.31109-1-jakub.kicinski@netronome.com> From: Daniel Borkmann Message-ID: <5af4eee7-437d-0cda-087a-00addffa9d05@iogearbox.net> Date: Tue, 12 Feb 2019 17:10:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20190212082039.31109-1-jakub.kicinski@netronome.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.100.2/25358/Tue Feb 12 11:37:40 2019) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 02/12/2019 09:20 AM, Jakub Kicinski wrote: > Currently bpf_offload_dev does not have any priv pointer, forcing > the drivers to work backwards from the netdev in program metadata. > This is not great given programs are conceptually associated with > the offload device, and it means one or two unnecessary deferences. > Add a priv pointer to bpf_offload_dev. > > Signed-off-by: Jakub Kicinski > Reviewed-by: Quentin Monnet Applied, thanks!