From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3353C9DCC5 for ; Tue, 13 Oct 2020 02:42:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 89EA92072C for ; Tue, 13 Oct 2020 02:42:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="V7Z8AV8X" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728465AbgJMB5J (ORCPT ); Mon, 12 Oct 2020 21:57:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726168AbgJMB5J (ORCPT ); Mon, 12 Oct 2020 21:57:09 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 325E9C0613D0; Mon, 12 Oct 2020 18:57:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:References:Cc:To:From:Subject:Sender :Reply-To:Content-ID:Content-Description; bh=bofq6aL5/+29OZsHkddC1oB1vsNZ0db2q5pYJHTnMUQ=; b=V7Z8AV8Xtib3nBBeqBFkaHoOj6 M+hjTGZc9UkYF0l/s8IUvD50nTKjpAgaNSWPlZwfX1z+qzeZq2rk8fcLfHzWG56VZqbOVVnOi4xEe 5LaoPCylHKs6v9VE6s60Cw8X1nYKl7oY2Cvjyc4MgTfaOJH0oAw0XkWj2iM9chRv+JhIkg4rJBgCt Knw1bXklm4JtT6GHkAnvj/Vm9Dspje1W9/Y55josQ+H2hxfhFmCQjKEZSdCQqvDIHx9UHzUXdzbl6 SWBcxg9lJFIyqPaRgl0QASA2TmYuNegMxcwv5YwJc/5KJH8ZZuECKkfowS22OuaFlHa7FGLbPrZD/ 259McASA==; Received: from [2601:1c0:6280:3f0::507c] by casper.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kS9Yi-0003ts-LD; Tue, 13 Oct 2020 01:57:01 +0000 Subject: Re: [PATCH v2 2/6] ASoC: SOF: Introduce descriptors for SOF client From: Randy Dunlap To: Pierre-Louis Bossart , Dave Ertman , alsa-devel@alsa-project.org Cc: tiwai@suse.de, broonie@kernel.org, linux-rdma@vger.kernel.org, jgg@nvidia.com, dledford@redhat.com, netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org, gregkh@linuxfoundation.org, ranjani.sridharan@linux.intel.com, fred.oh@linux.intel.com, parav@mellanox.com, shiraz.saleem@intel.com, dan.j.williams@intel.com, kiran.patil@intel.com References: <20201005182446.977325-1-david.m.ertman@intel.com> <20201005182446.977325-3-david.m.ertman@intel.com> <076a0c53-0738-270e-845f-0ac968a4ea78@infradead.org> <9ef98f33-a0d3-579d-26e0-6046dd593eef@infradead.org> Message-ID: <5b447b78-626d-2680-8a48-53493e2084a2@infradead.org> Date: Mon, 12 Oct 2020 18:56:55 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <9ef98f33-a0d3-579d-26e0-6046dd593eef@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 10/12/20 6:55 PM, Randy Dunlap wrote: > On 10/12/20 6:31 PM, Pierre-Louis Bossart wrote: >> >>>> +config SND_SOC_SOF_CLIENT >>>> +    tristate >>>> +    select ANCILLARY_BUS >>>> +    help >>>> +      This option is not user-selectable but automagically handled by >>>> +      'select' statements at a higher level >>>> + >>>> +config SND_SOC_SOF_CLIENT_SUPPORT >>>> +    bool "SOF enable clients" >>> >>> Tell users what "SOF" means. >> >> This option can only be reached if the user already selected the topic-level option. From there on the SOF acronym is used. Is this not enough? > > Yes, that's enough. I didn't see it. Sorry about that. Huh. I still don't see that Kconfig option. Which patch is it in? I only saw patches 1,2,3 on LKML. >> config SND_SOC_SOF_TOPLEVEL >>     bool "Sound Open Firmware Support" >>     help >>       This adds support for Sound Open Firmware (SOF). SOF is a free and >>       generic open source audio DSP firmware for multiple devices. >>       Say Y if you have such a device that is supported by SOF. >> >>> >>>> +    depends on SND_SOC_SOF >>>> +    help >>>> +      This adds support for ancillary client devices to separate out the debug >>>> +      functionality for IPC tests, probes etc. into separate devices. This >>>> +      option would also allow adding client devices based on DSP FW >>> >>> spell out firmware >> >> agree on this one. >> >>> >>>> +      capabilities and ACPI/OF device information. >>>> +      Say Y if you want to enable clients with SOF. >>>> +      If unsure select "N". >>>> + >>> >>> > > thanks. > -- ~Randy