From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52CDCC10F14 for ; Tue, 15 Oct 2019 09:19:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 23F022064B for ; Tue, 15 Oct 2019 09:19:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729592AbfJOJTP (ORCPT ); Tue, 15 Oct 2019 05:19:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:15811 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725980AbfJOJTP (ORCPT ); Tue, 15 Oct 2019 05:19:15 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 912F2309BDBC; Tue, 15 Oct 2019 09:19:14 +0000 (UTC) Received: from ovpn-116-35.ams2.redhat.com (ovpn-116-35.ams2.redhat.com [10.36.116.35]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2647519C7F; Tue, 15 Oct 2019 09:19:11 +0000 (UTC) Message-ID: <5ba8b82764c8b51744f9c77355c2c917e9206d19.camel@redhat.com> Subject: Re: [PATCH net] sunrpc: fix UDP memory accounting for v4.4 kernel From: Paolo Abeni To: JABLONSKY Jan , "netdev@vger.kernel.org" Cc: Trond Myklebust , Anna Schumaker , "J. Bruce Fields" , Jeff Layton , "David S. Miller" , "linux-nfs@vger.kernel.org" , Jan Stancek Date: Tue, 15 Oct 2019 11:19:11 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.32.4 (3.32.4-1.fc30) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Tue, 15 Oct 2019 09:19:14 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi, On Tue, 2019-10-15 at 07:21 +0000, JABLONSKY Jan wrote: > The same warnings reported by Jan Stancek may appear also on 4.4 > Based on Paolo Abeni's work. > > WARNING: at net/ipv4/af_inet.c:155 > CPU: 1 PID: 214 Comm: kworker/1:1H Not tainted 4.4.166 #1 > Workqueue: rpciod .xprt_autoclose > task: c0000000366f57c0 ti: c000000034134000 task.ti: c000000034134000 > NIP [c000000000662268] .inet_sock_destruct+0x158/0x200 > > Based on: "[net] sunrpc: fix UDP memory accounting" Since your goal here is the inclusion into the 4.4.y stable tree, you should follow the instructions listed here: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html elsewhere I guess your patch will not be processed properly. The relevant commit message is merged into Linus tree since some time and some minor modifications are needed, so you may likely follow option 3. Cheers, Paolo