From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21682C46467 for ; Tue, 10 Jan 2023 11:17:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232721AbjAJLRu (ORCPT ); Tue, 10 Jan 2023 06:17:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57488 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231149AbjAJLRp (ORCPT ); Tue, 10 Jan 2023 06:17:45 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58DD4210 for ; Tue, 10 Jan 2023 03:17:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673349421; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7R6k4XeSSfrouTet4Pl7FYt1MDO+biHA3LgQPUZKzOM=; b=PkdKWIR7QPEzuFMnMppcCEVq3ibLSxh0HQLEwGs1nIqdUTWk5+l53vb65OugsT1Sj7BjQp d4U+y+bqLJNkcsTb62HK4m4JUVWZzP3q4lKGndNVtZ65nJdGgTdU23aJTAOxEYdzvouW2O 1giirtF38N5mhTq5laph7clukkLRoiQ= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-308-By6Vtch8NZy3YzvqFLpOIw-1; Tue, 10 Jan 2023 06:17:00 -0500 X-MC-Unique: By6Vtch8NZy3YzvqFLpOIw-1 Received: by mail-qk1-f197.google.com with SMTP id bi3-20020a05620a318300b00702545f73d5so8461205qkb.8 for ; Tue, 10 Jan 2023 03:17:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=7R6k4XeSSfrouTet4Pl7FYt1MDO+biHA3LgQPUZKzOM=; b=BcePUGb6MKYebquMnjdArX6lqoNbLtz/rCwwNo3ysIagGXaZukW8BexLkLe1y2/VLB DRSyu8bw1XtC+IDsNyF31GxqwbFenDzwUYClBlcl6deTz8xOyM/Kk7raf7uQP8+hO9wW 0tJNeNJsKdj3dJtb6qPJduFg0ipCJI03ZlzQHqVUST4ee1T/xW9VgpO5kmg4fEBYBqB0 WCPaWkqobfbKe4Kk7yVmls1kDJ3I393WZKfVXeXXEb8ClC2FdrFOD5pMj9IG/BXQxVcV B1GT3ntzbhbMxVHvkHsLvaWh2FXTh9LT6/Dzoau/tlxWl9+JbDBO77JoTAkt8GjHIof4 Ob2w== X-Gm-Message-State: AFqh2kq19QEpECpToYmN88gEjADuByrSQf5LRT086CEC0X57oUQzVMho Ec/naIfRYSDKC2Ee1i/t7xgKMOeYS4y8unIwL+rZKhVY0cbADgRoCEg+R9cmxp1hK//S+HQppey EspFFbt4IoTYqys6P X-Received: by 2002:ac8:520c:0:b0:3a8:1079:b844 with SMTP id r12-20020ac8520c000000b003a81079b844mr89443414qtn.46.1673349419765; Tue, 10 Jan 2023 03:16:59 -0800 (PST) X-Google-Smtp-Source: AMrXdXt7LAw0VjeSUK8wkVXMaLsnRFvPYmNquEuKr7XZHAByB6NkEWLdJSItXvzP6gLV6c7Tmr1r8Q== X-Received: by 2002:ac8:520c:0:b0:3a8:1079:b844 with SMTP id r12-20020ac8520c000000b003a81079b844mr89443387qtn.46.1673349419493; Tue, 10 Jan 2023 03:16:59 -0800 (PST) Received: from gerbillo.redhat.com (146-241-120-128.dyn.eolo.it. [146.241.120.128]) by smtp.gmail.com with ESMTPSA id k8-20020ac80748000000b0038b684a1642sm5839964qth.32.2023.01.10.03.16.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jan 2023 03:16:58 -0800 (PST) Message-ID: <5bd7ee34ead313785951defbf3069b64d4338a45.camel@redhat.com> Subject: Re: [PATCH net-next v3 01/11] net: mdio: Add dedicated C45 API to MDIO bus drivers From: Paolo Abeni To: Michael Walle , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Jose Abreu , Sergey Shtylyov , Wei Fang , Shenwei Wang , Clark Wang , NXP Linux Team , Sean Wang , Landen Chao , DENG Qingfang , Florian Fainelli , Vladimir Oltean , Matthias Brugger Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Andrew Lunn , Geert Uytterhoeven , Vladimir Oltean Date: Tue, 10 Jan 2023 12:16:53 +0100 In-Reply-To: <20221227-v6-2-rc1-c45-seperation-v3-1-ade1deb438da@walle.cc> References: <20221227-v6-2-rc1-c45-seperation-v3-0-ade1deb438da@walle.cc> <20221227-v6-2-rc1-c45-seperation-v3-1-ade1deb438da@walle.cc> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 2023-01-09 at 16:30 +0100, Michael Walle wrote: > diff --git a/include/linux/phy.h b/include/linux/phy.h > index 6378c997ded5..65844f0a7fb3 100644 > --- a/include/linux/phy.h > +++ b/include/linux/phy.h > @@ -364,6 +364,11 @@ struct mii_bus { > int (*read)(struct mii_bus *bus, int addr, int regnum); > /** @write: Perform a write transfer on the bus */ > int (*write)(struct mii_bus *bus, int addr, int regnum, u16 val); > + /** @read: Perform a C45 read transfer on the bus */ Minor nit: s/@read/@read_c45/ > + int (*read_c45)(struct mii_bus *bus, int addr, int devnum, int regnum); > + /** @write: Perform a C45 write transfer on the bus */ Mutatis mutandis, same thing here. Thanks! Paolo