From: Florian Fainelli <f.fainelli@gmail.com>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>,
miaoqing@codeaurora.org, rsalvaterra@gmail.com,
"Toke Høiland-Jørgensen" <toke@toke.dk>,
"Sepehrdad, Pouyan" <pouyans@qti.qualcomm.com>,
ath9k-devel <ath9k-devel@qca.qualcomm.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"Kalle Valo" <kvalo@kernel.org>,
"Dominik Brodowski" <linux@dominikbrodowski.net>,
"Linux Crypto Mailing List" <linux-crypto@vger.kernel.org>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
LKML <linux-kernel@vger.kernel.org>,
Netdev <netdev@vger.kernel.org>
Cc: "Toke Høiland-Jørgensen" <toke@redhat.com>
Subject: Re: [PATCH v2] ath9k: use hw_random API instead of directly dumping into random.c
Date: Tue, 15 Feb 2022 19:13:39 -0800 [thread overview]
Message-ID: <5c23585b-7865-54fb-3835-12e58a7aee46@gmail.com> (raw)
In-Reply-To: <20220216000230.22625-1-Jason@zx2c4.com>
On 2/15/2022 4:02 PM, Jason A. Donenfeld wrote:
> Hardware random number generators are supposed to use the hw_random
> framework. This commit turns ath9k's kthread-based design into a proper
> hw_random driver.
>
> This compiles, but I have no hardware or other ability to determine
> whether it works. I'll leave further development up to the ath9k
> and hw_random maintainers.
>
> Cc: Toke Høiland-Jørgensen <toke@redhat.com>
> Cc: Kalle Valo <kvalo@kernel.org>
> Cc: Dominik Brodowski <linux@dominikbrodowski.net>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
> ---
[snip]
> if (!AR_SREV_9300_20_OR_LATER(ah))
> return;
>
> - sc->rng_task = kthread_run(ath9k_rng_kthread, sc, "ath9k-hwrng");
> - if (IS_ERR(sc->rng_task))
> - sc->rng_task = NULL;
> + sc->rng_ops.name = "ath9k";
You will have to give this instance an unique name because there can be
multiple ath9k adapters registered in a given system (like Wi-Fi
routers), and one of the first thing hwrng_register() does is ensure
that there is not an existing rng with the same name.
Maybe using a combination of ath9k + dev_name() ought to be unique enough?
--
Florian
next prev parent reply other threads:[~2022-02-16 3:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAHmME9rkTP7bJBDvnejQ6BGPu13qpHKbtnjt3h33NEaTnYLirg@mail.gmail.com>
2022-02-15 15:38 ` ath9k should perhaps use hw_random api? Jason A. Donenfeld
2022-02-15 16:28 ` [PATCH] ath9k: use hw_random API instead of directly dumping into random.c Jason A. Donenfeld
2022-02-15 22:55 ` Rui Salvaterra
2022-02-15 23:22 ` Toke Høiland-Jørgensen
2022-02-15 23:52 ` Jason A. Donenfeld
2022-02-16 0:02 ` [PATCH v2] " Jason A. Donenfeld
2022-02-16 3:13 ` Florian Fainelli [this message]
2022-02-16 10:43 ` Jason A. Donenfeld
2022-02-16 11:33 ` [PATCH v3] " Jason A. Donenfeld
2022-02-16 13:27 ` Rui Salvaterra
2022-02-17 13:51 ` Toke Høiland-Jørgensen
2022-02-21 10:22 ` Kalle Valo
2022-02-22 10:01 ` Ard Biesheuvel
2022-02-22 10:13 ` Jason A. Donenfeld
2022-02-16 5:38 ` [PATCH v2] " Kalle Valo
2022-02-16 7:15 ` Dominik Brodowski
2022-02-16 7:11 ` [PATCH] " Dominik Brodowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c23585b-7865-54fb-3835-12e58a7aee46@gmail.com \
--to=f.fainelli@gmail.com \
--cc=Jason@zx2c4.com \
--cc=ath9k-devel@qca.qualcomm.com \
--cc=herbert@gondor.apana.org.au \
--cc=kvalo@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=miaoqing@codeaurora.org \
--cc=netdev@vger.kernel.org \
--cc=pouyans@qti.qualcomm.com \
--cc=rsalvaterra@gmail.com \
--cc=toke@redhat.com \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).