From: Rob Herring <robh@kernel.org>
To: Alexandru Ardelean <alexandru.ardelean@analog.com>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, davem@davemloft.net,
peppe.cavallaro@st.com, alexandre.torgue@st.com,
--cc=andrew@lunn.ch
Subject: Re: [PATCH 2/2] dt-bindings: net: dwmac: document 'mac-mode' property
Date: Fri, 13 Sep 2019 15:36:13 +0100 [thread overview]
Message-ID: <5d7ba95d.1c69fb81.dabe4.8057@mx.google.com> (raw)
In-Reply-To: <20190906130256.10321-2-alexandru.ardelean@analog.com>
On Fri, Sep 06, 2019 at 04:02:56PM +0300, Alexandru Ardelean wrote:
> This change documents the 'mac-mode' property that was introduced in the
> 'stmmac' driver to support passive mode converters that can sit in-between
> the MAC & PHY.
>
> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
> ---
> Documentation/devicetree/bindings/net/snps,dwmac.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> index c78be15704b9..ebe4537a7cce 100644
> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> @@ -112,6 +112,14 @@ properties:
> reset-names:
> const: stmmaceth
>
> + mac-mode:
> + maxItems: 1
Is this an array because {min,max}Items is for arrays? It should be
defined as a string with possible values.
As this property is the same as another, you can do this:
$ref: ethernet-controller.yaml#/properties/phy-connection-type
Unless only a small subset of those values are valid here, then you may
want to list them here.
> + description:
> + The property is identical to 'phy-mode', and assumes that there is mode
> + converter in-between the MAC & PHY (e.g. GMII-to-RGMII). This converter
> + can be passive (no SW requirement), and requires that the MAC operate
> + in a different mode than the PHY in order to function.
> +
> snps,axi-config:
> $ref: /schemas/types.yaml#definitions/phandle
> description:
> --
> 2.20.1
>
next prev parent reply other threads:[~2019-09-13 14:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-06 13:02 [PATCH 1/2] net: stmmac: implement support for passive mode converters via dt Alexandru Ardelean
2019-09-06 13:02 ` [PATCH 2/2] dt-bindings: net: dwmac: document 'mac-mode' property Alexandru Ardelean
2019-09-11 14:28 ` David Miller
2019-09-13 14:36 ` Rob Herring [this message]
2019-09-16 6:49 ` Ardelean, Alexandru
2019-09-17 7:21 ` Ardelean, Alexandru
2019-09-11 14:28 ` [PATCH 1/2] net: stmmac: implement support for passive mode converters via dt David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d7ba95d.1c69fb81.dabe4.8057@mx.google.com \
--to=robh@kernel.org \
--cc=--cc=andrew@lunn.ch \
--cc=alexandre.torgue@st.com \
--cc=alexandru.ardelean@analog.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).