From: Florian Fainelli <f.fainelli@gmail.com>
To: Heiner Kallweit <hkallweit1@gmail.com>,
Russell King - ARM Linux admin <linux@armlinux.org.uk>,
Andrew Lunn <andrew@lunn.ch>
Cc: David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 1/3] net: phy: add and use phy_check_downshift
Date: Thu, 19 Mar 2020 09:55:32 -0700 [thread overview]
Message-ID: <5e5c647b-f05d-d9d3-0554-68af99ee3f55@gmail.com> (raw)
In-Reply-To: <92689def-4bbf-8988-3137-f3cfb940e9fc@gmail.com>
Le 2020-03-19 à 09:36, Heiner Kallweit a écrit :
> *Downshift reporting/warning*
> In most cases downshift is caused by some problem with the cabling.
> Users like the typical Ubuntu user in most cases are not familiar
> with the concept of PHY downshift and what causes a downshift.
> Therefore it's not sufficient to just report a downshift, we have
> to provide the user with a hint what to do.
> Adding the "downshifted" info to phy_print_status() is a good idea,
> however I'd see it as an optional addition to the mentioned hint
> to the user what to do.
> The info "unknown downshift" IMO would just cause confusion. If we
> have nothing to say, then why say something. Also users may interpret
> "unknown" as "there's something wrong".
Ideally we would also have support for cable testing as well which would
allow users to know what to do next to figure out why their link speed
is not what they had hoped for. That does require a specific PHY driver
though as there is no standard way to obtain that information.
FWIW, a bunch of drivers like tg3, e1000e, igc and possibly others do
report when downshifting occurs, of course not all of those in that list
use the PHY library.
--
Florian
next prev parent reply other threads:[~2020-03-19 16:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 21:27 [PATCH net-next 0/3] net: phy: add and use phy_check_downshift Heiner Kallweit
2020-03-18 21:29 ` [PATCH net-next 1/3] " Heiner Kallweit
2020-03-18 23:21 ` Russell King - ARM Linux admin
2020-03-19 7:30 ` Heiner Kallweit
2020-03-19 11:25 ` Russell King - ARM Linux admin
2020-03-19 13:04 ` Andrew Lunn
2020-03-19 13:58 ` Russell King - ARM Linux admin
2020-03-19 16:36 ` Heiner Kallweit
2020-03-19 16:55 ` Florian Fainelli [this message]
2020-03-19 17:04 ` Heiner Kallweit
2020-03-19 17:08 ` Russell King - ARM Linux admin
2020-03-20 8:07 ` Heiner Kallweit
2020-03-19 9:06 ` Andrew Lunn
2020-03-19 9:10 ` Andrew Lunn
2020-03-18 21:29 ` [PATCH net-next 2/3] net: phy: marvell: remove downshift warning now that phylib takes care Heiner Kallweit
2020-03-18 21:31 ` [PATCH net-next 3/3] net: phy: aquantia: " Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e5c647b-f05d-d9d3-0554-68af99ee3f55@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).