From: Eric Dumazet <eric.dumazet@gmail.com>
To: Allen Pais <allen.lkml@gmail.com>, davem@davemloft.net
Cc: gerrit@erg.abdn.ac.uk, kuba@kernel.org, edumazet@google.com,
kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org,
johannes@sipsolutions.net, alex.aring@gmail.com,
stefan@datenfreihafen.org, santosh.shilimkar@oracle.com,
jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us,
steffen.klassert@secunet.com, herbert@gondor.apana.org.au,
netdev@vger.kernel.org, Allen Pais <apais@linux.microsoft.com>,
Romain Perier <romain.perier@gmail.com>
Subject: Re: [net-next v2 6/8] net: sched: convert tasklets to use new tasklet_setup() API
Date: Wed, 7 Oct 2020 18:52:17 +0200 [thread overview]
Message-ID: <5f057822-0d9a-0643-6a1e-118e306c6bb1@gmail.com> (raw)
In-Reply-To: <20201007101219.356499-7-allen.lkml@gmail.com>
On 10/7/20 12:12 PM, Allen Pais wrote:
> From: Allen Pais <apais@linux.microsoft.com>
>
> In preparation for unconditionally passing the
> struct tasklet_struct pointer to all tasklet
> callbacks, switch to using the new tasklet_setup()
> and from_tasklet() to pass the tasklet pointer explicitly.
>
> Signed-off-by: Romain Perier <romain.perier@gmail.com>
> Signed-off-by: Allen Pais <apais@linux.microsoft.com>
> ---
> net/sched/sch_atm.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/net/sched/sch_atm.c b/net/sched/sch_atm.c
> index 1c281cc81..0a4452178 100644
> --- a/net/sched/sch_atm.c
> +++ b/net/sched/sch_atm.c
> @@ -466,10 +466,11 @@ drop: __maybe_unused
> * non-ATM interfaces.
> */
>
> -static void sch_atm_dequeue(unsigned long data)
> +static void sch_atm_dequeue(struct tasklet_struct *t)
> {
> - struct Qdisc *sch = (struct Qdisc *)data;
> - struct atm_qdisc_data *p = qdisc_priv(sch);
> + struct atm_qdisc_data *p = from_tasklet(p, t, task);
> + struct Qdisc *sch = (struct Qdisc *)((char *) p -
> + QDISC_ALIGN(sizeof(struct Qdisc)));
Oh well. I would rather get rid of QDISC_ALIGN() completely, instead
of spreading it all over the places.
I have sent https://patchwork.ozlabs.org/project/netdev/patch/20201007165111.172419-1-eric.dumazet@gmail.com/
next prev parent reply other threads:[~2020-10-07 16:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-07 10:12 [net-next v2 0/8] net: convert tasklets to use new Allen Pais
2020-10-07 10:12 ` [net-next v2 1/8] net: dccp: convert tasklets to use new tasklet_setup() API Allen Pais
2020-10-07 10:12 ` [net-next v2 2/8] net: ipv4: " Allen Pais
2020-10-07 10:12 ` [net-next v2 3/8] net: mac80211: " Allen Pais
2020-10-07 10:55 ` Johannes Berg
2020-10-07 10:57 ` Allen Pais
2020-10-07 10:12 ` [net-next v2 4/8] net: mac802154: " Allen Pais
2020-10-07 10:12 ` [net-next v2 5/8] net: rds: " Allen Pais
2020-10-07 10:12 ` [net-next v2 6/8] net: sched: " Allen Pais
2020-10-07 16:52 ` Eric Dumazet [this message]
2020-10-07 10:12 ` [net-next v2 7/8] net: smc: " Allen Pais
2020-10-07 19:17 ` Karsten Graul
2020-10-07 10:12 ` [net-next v2 8/8] net: xfrm: " Allen Pais
2020-10-09 15:44 ` [net-next v2 0/8] net: convert tasklets to use new Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f057822-0d9a-0643-6a1e-118e306c6bb1@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=alex.aring@gmail.com \
--cc=allen.lkml@gmail.com \
--cc=apais@linux.microsoft.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gerrit@erg.abdn.ac.uk \
--cc=herbert@gondor.apana.org.au \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=romain.perier@gmail.com \
--cc=santosh.shilimkar@oracle.com \
--cc=stefan@datenfreihafen.org \
--cc=steffen.klassert@secunet.com \
--cc=xiyou.wangcong@gmail.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).