From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Hayes Wang <hayeswang@realtek.com>, netdev@vger.kernel.org
Cc: nic_swsd@realtek.com, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH net-next] r8153_ecm: avoid to be prior to r8152 driver
Date: Mon, 16 Nov 2020 10:18:13 +0100 [thread overview]
Message-ID: <5f3db229-940c-c8ed-257b-0b4b3dd2afbb@samsung.com> (raw)
In-Reply-To: <1394712342-15778-393-Taiwan-albertk@realtek.com>
Hi
On 16.11.2020 07:52, Hayes Wang wrote:
> Avoid r8153_ecm is compiled as built-in, if r8152 driver is compiled
> as modules. Otherwise, the r8153_ecm would be used, even though the
> device is supported by r8152 driver.
>
> Fixes: c1aedf015ebd ("net/usb/r8153_ecm: support ECM mode for RTL8153")
> Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Signed-off-by: Hayes Wang <hayeswang@realtek.com>
Yes, this fixes this issue, although I would prefer a separate Kconfig
entry for r8153_ecm with proper dependencies instead of this ifdefs in
Makefile.
Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> drivers/net/usb/Makefile | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/usb/Makefile b/drivers/net/usb/Makefile
> index 99381e6bea78..98f4c100955e 100644
> --- a/drivers/net/usb/Makefile
> +++ b/drivers/net/usb/Makefile
> @@ -13,7 +13,7 @@ obj-$(CONFIG_USB_LAN78XX) += lan78xx.o
> obj-$(CONFIG_USB_NET_AX8817X) += asix.o
> asix-y := asix_devices.o asix_common.o ax88172a.o
> obj-$(CONFIG_USB_NET_AX88179_178A) += ax88179_178a.o
> -obj-$(CONFIG_USB_NET_CDCETHER) += cdc_ether.o r8153_ecm.o
> +obj-$(CONFIG_USB_NET_CDCETHER) += cdc_ether.o
> obj-$(CONFIG_USB_NET_CDC_EEM) += cdc_eem.o
> obj-$(CONFIG_USB_NET_DM9601) += dm9601.o
> obj-$(CONFIG_USB_NET_SR9700) += sr9700.o
> @@ -41,3 +41,11 @@ obj-$(CONFIG_USB_NET_QMI_WWAN) += qmi_wwan.o
> obj-$(CONFIG_USB_NET_CDC_MBIM) += cdc_mbim.o
> obj-$(CONFIG_USB_NET_CH9200) += ch9200.o
> obj-$(CONFIG_USB_NET_AQC111) += aqc111.o
> +
> +ifdef CONFIG_USB_NET_CDCETHER
> +ifeq ($(CONFIG_USB_RTL8152), m)
> +obj-$(CONFIG_USB_RTL8152) += r8153_ecm.o
> +else
> +obj-$(CONFIG_USB_NET_CDCETHER) += r8153_ecm.o
> +endif
> +endif
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
next prev parent reply other threads:[~2020-11-16 10:32 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 12:33 [PATCH] net/usb/r8153_ecm: support ECM mode for RTL8153 Hayes Wang
2020-10-29 15:04 ` kernel test robot
2020-10-30 3:23 ` [PATCH net-next v2] " Hayes Wang
2020-10-31 23:08 ` Jakub Kicinski
2020-11-02 7:20 ` Hayes Wang
2020-11-02 19:47 ` Jakub Kicinski
2020-11-03 9:32 ` Greg Kroah-Hartman
2020-11-03 9:51 ` Hayes Wang
2020-11-03 16:15 ` Jakub Kicinski
2020-11-04 1:39 ` Hayes Wang
2020-11-04 1:44 ` Jakub Kicinski
2020-11-03 9:46 ` [PATCH net-next v3 0/2] drivers/net/usb: " Hayes Wang
2020-11-03 9:46 ` [PATCH net-next v3 1/2] include/linux/usb: new header file for the vendor ID of USB devices Hayes Wang
2020-11-03 9:55 ` Greg KH
2020-11-03 9:46 ` [PATCH net-next v3 2/2] net/usb/r8153_ecm: support ECM mode for RTL8153 Hayes Wang
2020-11-04 2:19 ` [PATCH net-next v2 RESEND] " Hayes Wang
2020-11-06 1:00 ` Jakub Kicinski
[not found] ` <CGME20201113152938eucas1p2c8500d9d3d0c892c7c2a2d56b32fedc0@eucas1p2.samsung.com>
2020-11-13 15:29 ` Marek Szyprowski
2020-11-16 6:52 ` [PATCH net-next] r8153_ecm: avoid to be prior to r8152 driver Hayes Wang
2020-11-16 9:18 ` Marek Szyprowski [this message]
2020-11-16 17:02 ` Jakub Kicinski
2020-11-17 1:50 ` Hayes Wang
2020-11-17 16:11 ` Jakub Kicinski
2020-11-18 1:21 ` Hayes Wang
2020-11-18 6:43 ` [PATCH net-next v2] " Hayes Wang
2020-11-18 8:18 ` Marek Szyprowski
2020-11-19 16:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f3db229-940c-c8ed-257b-0b4b3dd2afbb@samsung.com \
--to=m.szyprowski@samsung.com \
--cc=hayeswang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).