From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94513C43381 for ; Tue, 26 Feb 2019 06:42:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 57811213A2 for ; Tue, 26 Feb 2019 06:42:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NFrkEibm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725993AbfBZGmU (ORCPT ); Tue, 26 Feb 2019 01:42:20 -0500 Received: from mail-pf1-f179.google.com ([209.85.210.179]:40906 "EHLO mail-pf1-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725879AbfBZGmU (ORCPT ); Tue, 26 Feb 2019 01:42:20 -0500 Received: by mail-pf1-f179.google.com with SMTP id h1so5736527pfo.7 for ; Mon, 25 Feb 2019 22:42:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:from:subject:message-id:date:user-agent:mime-version :content-language:content-transfer-encoding; bh=TmmFDILQWrNzR/VhZUjvk9UlNYybFlQSWCboXIszXtc=; b=NFrkEibmeMhTMCYV7carFWABIHNWQKtrGkiLuWtlPORGg+TJj4sirANLSltJJuFzSy fnEszJeTIkP9+owOiP1QJ0AVY2T/r2h5bTkOsPYONsotVjKlK25tAzwZ9y+TtX3hYnnT HE/Rh/R+CT4+E4F0Ykj9Qfi044d9olpYPeQTtlJHnTmZ792Kxbm5KDZiToAbN0P/so5x YALU9+4RQSFxBvV95jsKDcCDn0dTbnY3hTKPL7X+wXF26O7s6ZJJ2qSKdutyHAeMKAvo wecUxe/O8FD70svI0HQ2odwsG+ilwu19CkGd38N9eblgklNaeFGJsWw9qfOo88JmziGo 8RKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:from:subject:message-id:date:user-agent :mime-version:content-language:content-transfer-encoding; bh=TmmFDILQWrNzR/VhZUjvk9UlNYybFlQSWCboXIszXtc=; b=skSPo9x0PyJ5VwvjMYjbL4ZB+v3BnalgY0o7B3Cm22Dbug1v2BenIxmNEBVnu4KxZZ 6A1NUx14fT/2mablwQ+W7akKSHBsIGnKP6BD5kczUlDv9Nzu9VwQIumwEThWHkRe0cAW hFmJH9l0FyyxWg3ORjuFstTlSCC6QHHQmWIYWYmAJSMkMli/vohEmI/1zYvSqPudX47R DXkyQV+lLrfTbj46pLGPG5Vw9x+YaAZ83eKJ62iFh5YYuBVhknthVP23zEicfZwrN50P L50wI37n8tjSMwefIGDIQDo4XbHSiDLhJuhajMTjWrzoUUAA7RdE+G01zDfj/M+cTKd0 idLg== X-Gm-Message-State: AHQUAuZkFeJA4zvTDEzc+qH9dGE14nVae5fEOZGbIsrdLt3Mv2Br6Sw1 M7kkTkArlwSovZt9iiFuZ/4= X-Google-Smtp-Source: AHgI3IYblNLmqtz1ya5lsb9sBGalBEYvWciAl4VyZKUDeA8Raii1+hMTGgmsYIImStaPwn71G94dfQ== X-Received: by 2002:a62:568e:: with SMTP id h14mr25352886pfj.134.1551163339320; Mon, 25 Feb 2019 22:42:19 -0800 (PST) Received: from [192.168.86.235] (c-73-241-150-70.hsd1.ca.comcast.net. [73.241.150.70]) by smtp.gmail.com with ESMTPSA id q75sm23951417pfa.38.2019.02.25.22.42.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Feb 2019 22:42:18 -0800 (PST) To: John Fastabend , Networking , Jamal Hadi Salim , Cong Wang , Jiri Pirko From: Eric Dumazet Subject: [BUG] net/sched : qlen can not really be per cpu ? Message-ID: <5fb87db3-d5bd-714b-213d-6821f4bf37da@gmail.com> Date: Mon, 25 Feb 2019 22:42:17 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org HTB + pfifo_fast as a leaf qdisc hits badly the following warning in htb_activate() : WARN_ON(cl->level || !cl->leaf.q || !cl->leaf.q->q.qlen); This is because pfifo_fast does not update sch->q.qlen, but per cpu counters. So cl->leaf.q->q.qlen is zero. HFSC, CBQ, DRR, QFQ have the same problem. Any ideas how we can fix this ? Thanks !