netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: wenxu@ucloud.cn, marcelo.leitner@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH iproute2-next v2] tc: flower: add tc conntrack inv ct_state support
Date: Sat, 23 Jan 2021 11:17:36 -0700	[thread overview]
Message-ID: <602327f6-8bff-8d65-8e6c-82dc9b13898b@gmail.com> (raw)
In-Reply-To: <1611111132-25552-1-git-send-email-wenxu@ucloud.cn>

On 1/19/21 7:52 PM, wenxu@ucloud.cn wrote:
> From: wenxu <wenxu@ucloud.cn>
> 
> Matches on conntrack inv ct_state.
> 
> Signed-off-by: wenxu <wenxu@ucloud.cn>
> ---
> v2: change the description
> 
>  include/uapi/linux/pkt_cls.h | 1 +
>  man/man8/tc-flower.8         | 2 ++
>  tc/f_flower.c                | 1 +
>  3 files changed, 4 insertions(+)
> 
> diff --git a/include/uapi/linux/pkt_cls.h b/include/uapi/linux/pkt_cls.h
> index 449a639..e8f2aed 100644
> --- a/include/uapi/linux/pkt_cls.h
> +++ b/include/uapi/linux/pkt_cls.h
> @@ -563,6 +563,7 @@ enum {
>  	TCA_FLOWER_KEY_CT_FLAGS_ESTABLISHED = 1 << 1, /* Part of an existing connection. */
>  	TCA_FLOWER_KEY_CT_FLAGS_RELATED = 1 << 2, /* Related to an established connection. */
>  	TCA_FLOWER_KEY_CT_FLAGS_TRACKED = 1 << 3, /* Conntrack has occurred. */
> +	TCA_FLOWER_KEY_CT_FLAGS_INVALID = 1 << 4, /* Conntrack is invalid. */
>  };
>  
>  enum {
> diff --git a/man/man8/tc-flower.8 b/man/man8/tc-flower.8
> index eb9eb5f..f90117b 100644
> --- a/man/man8/tc-flower.8
> +++ b/man/man8/tc-flower.8
> @@ -312,6 +312,8 @@ new - New connection.
>  .TP
>  est - Established connection.
>  .TP
> +inv - The state is invalid. The packet couldn't be associated to a connection.
> +.TP
>  Example: +trk+est
>  .RE
>  .TP
> diff --git a/tc/f_flower.c b/tc/f_flower.c
> index 9d59d71..7d2df9d 100644
> --- a/tc/f_flower.c
> +++ b/tc/f_flower.c
> @@ -340,6 +340,7 @@ static struct flower_ct_states {
>  	{ "trk", TCA_FLOWER_KEY_CT_FLAGS_TRACKED },
>  	{ "new", TCA_FLOWER_KEY_CT_FLAGS_NEW },
>  	{ "est", TCA_FLOWER_KEY_CT_FLAGS_ESTABLISHED },
> +	{ "inv", TCA_FLOWER_KEY_CT_FLAGS_INVALID},
>  };
>  
>  static int flower_parse_ct_state(char *str, struct nlmsghdr *n)
> 

Fixed the space and applied to iproute2-next.

      parent reply	other threads:[~2021-01-23 18:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-20  2:52 [PATCH iproute2-next v2] tc: flower: add tc conntrack inv ct_state support wenxu
2021-01-20 16:25 ` Marcelo Ricardo Leitner
2021-01-23 18:17 ` David Ahern [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=602327f6-8bff-8d65-8e6c-82dc9b13898b@gmail.com \
    --to=dsahern@gmail.com \
    --cc=marcelo.leitner@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=wenxu@ucloud.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).