netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Joakim Zhang <qiangqing.zhang@nxp.com>,
	robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de
Cc: devicetree@vger.kernel.org, peng.fan@nxp.com, victor.liu@nxp.com,
	netdev@vger.kernel.org, pankaj.bansal@nxp.com,
	linux-kernel@vger.kernel.org, linux-can@vger.kernel.org,
	linux-imx@nxp.com, kernel@pengutronix.de
Subject: Re: [PATCH 3/6] dt-bindings: can: flexcan: add fsl, can-index property to indicate a resource
Date: Fri, 16 Oct 2020 08:20:18 +0200	[thread overview]
Message-ID: <604a66f6-83ea-630e-f479-fe62189de42a@pengutronix.de> (raw)
In-Reply-To: <20201016134320.20321-4-qiangqing.zhang@nxp.com>


[-- Attachment #1.1: Type: text/plain, Size: 1690 bytes --]

On 10/16/20 3:43 PM, Joakim Zhang wrote:
> For SoCs with SCU support, need setup stop mode via SCU firmware,
> so this property can help indicate a resource.
> 
> Signed-off-by: Joakim Zhang <qiangqing.zhang@nxp.com>
> ---
>  Documentation/devicetree/bindings/net/can/fsl-flexcan.txt | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
> index 6af67f5e581c..839c0c0064a2 100644
> --- a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
> +++ b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
> @@ -43,6 +43,10 @@ Optional properties:
>  		  0: clock source 0 (oscillator clock)
>  		  1: clock source 1 (peripheral clock)
>  
> +- fsl,can-index: The index of CAN instance.
> +                 For SoCs with SCU support, need setup stop mode via SCU firmware,
> +                 so this property can help indicate a resource.

This property is not CAN specific. So the name could be more general.

> +
>  - wakeup-source: enable CAN remote wakeup
>  
>  Example:
> @@ -54,4 +58,5 @@ Example:
>  		interrupt-parent = <&mpic>;
>  		clock-frequency = <200000000>; // filled in by bootloader
>  		fsl,clk-source = /bits/ 8 <0>; // select clock source 0 for PE
> +		fsl,can-index = /bits/ 8 <1>; // the second CAN instance
>  	};
> 

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2020-10-16  6:20 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-16 13:43 [PATCH 0/6] can: flexcan: add stop mode support for i.MX8QM Joakim Zhang
2020-10-16 13:43 ` [PATCH 1/6] firmware: imx: always export SCU symbols Joakim Zhang
2020-10-16 13:43 ` [PATCH 2/6] dt-bindings: can: flexcan: fix fsl,clk-source property Joakim Zhang
2020-10-16  6:21   ` Marc Kleine-Budde
2020-10-16  6:52     ` Joakim Zhang
2020-10-16 13:43 ` [PATCH 3/6] dt-bindings: can: flexcan: add fsl,can-index property to indicate a resource Joakim Zhang
2020-10-16  6:20   ` Marc Kleine-Budde [this message]
2020-10-16  6:52     ` [PATCH 3/6] dt-bindings: can: flexcan: add fsl, can-index " Joakim Zhang
2020-10-16  7:47       ` Marc Kleine-Budde
2020-10-16 13:43 ` [PATCH 4/6] can: flexcan: rename macro FLEXCAN_QUIRK_SETUP_STOP_MODE -> FLEXCAN_QUIRK_SETUP_STOP_MODE_GPR Joakim Zhang
2020-10-16  6:22   ` Marc Kleine-Budde
2020-10-16 13:43 ` [PATCH 5/6] can: flexcan: add CAN wakeup function for i.MX8QM Joakim Zhang
2020-10-16  5:59   ` Marc Kleine-Budde
2020-10-16  6:46     ` Joakim Zhang
2020-10-16  7:44       ` Marc Kleine-Budde
2020-10-16  6:18   ` Marc Kleine-Budde
2020-10-16  6:51     ` Joakim Zhang
2020-10-16 10:00       ` Joakim Zhang
2020-10-16 10:40         ` Marc Kleine-Budde
2020-10-16 10:57           ` Joakim Zhang
2020-10-16 13:43 ` [PATCH 6/6] can: flexcan: fix ECC function on LS1021A/LX2160A Joakim Zhang
2020-10-16  6:04   ` Marc Kleine-Budde
2020-10-16  6:49     ` Joakim Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=604a66f6-83ea-630e-f479-fe62189de42a@pengutronix.de \
    --to=mkl@pengutronix.de \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pankaj.bansal@nxp.com \
    --cc=peng.fan@nxp.com \
    --cc=qiangqing.zhang@nxp.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=victor.liu@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).