From: Marc Gonzalez <marc.w.gonzalez@free.fr>
To: Niklas Cassel <niklas.cassel@linaro.org>
Cc: Vinod Koul <vkoul@kernel.org>, David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
MSM <linux-arm-msm@vger.kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Nori Sekhar <nsekhar@ti.com>,
Peter Ujfalusi <peter.ujfalusi@ti.com>
Subject: Re: [PATCH net-next v3 2/2] net: phy: at803x: disable delay only for RGMII mode
Date: Tue, 19 Feb 2019 13:41:37 +0100 [thread overview]
Message-ID: <60e0143b-9032-4c31-0dbb-9f2518f79601@free.fr> (raw)
In-Reply-To: <20190219123339.GA13172@centauri.lan>
On 19/02/2019 13:33, Niklas Cassel wrote:
> However, since the bootloader might have enabled delay on
> TX, I still think that this patch does the right thing by
> starting out with disabling delays for both RX and TX.
>
> But we should probably make the comment more elaborate:
>
> The value after HW reset is RX delay enabled and TX delay disabled.
> The value after SW reset is RX delay enabled, while TX delay retains
> the value before reset.
> In order to not depend on reset values, start off by disabling both
> delays.
Ultimately, the two patches do the same thing, AFAICT ;-)
I was just arguing that my way was better because... errr... because
it was my way! :-)
Regards.
next prev parent reply other threads:[~2019-02-19 12:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-19 6:17 [PATCH net-next v3 0/2] net: phy: at803x: Update delays for RGMII modes Vinod Koul
2019-02-19 6:17 ` [PATCH net-next v3 1/2] net: phy: at803x: don't inline helpers Vinod Koul
2019-02-19 11:44 ` Marc Gonzalez
2019-02-19 6:18 ` [PATCH net-next v3 2/2] net: phy: at803x: disable delay only for RGMII mode Vinod Koul
2019-02-19 11:57 ` Marc Gonzalez
2019-02-19 12:33 ` Niklas Cassel
2019-02-19 12:41 ` Marc Gonzalez [this message]
2019-02-19 8:09 ` [PATCH net-next v3 0/2] net: phy: at803x: Update delays for RGMII modes Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60e0143b-9032-4c31-0dbb-9f2518f79601@free.fr \
--to=marc.w.gonzalez@free.fr \
--cc=andrew@lunn.ch \
--cc=bjorn.andersson@linaro.org \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=niklas.cassel@linaro.org \
--cc=nsekhar@ti.com \
--cc=peter.ujfalusi@ti.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).