From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B12AC433DF for ; Thu, 21 May 2020 22:46:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 23358207D8 for ; Thu, 21 May 2020 22:46:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730684AbgEUWqX convert rfc822-to-8bit (ORCPT ); Thu, 21 May 2020 18:46:23 -0400 Received: from mga01.intel.com ([192.55.52.88]:36682 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730371AbgEUWqX (ORCPT ); Thu, 21 May 2020 18:46:23 -0400 IronPort-SDR: E+DLNaujHMbB2glVcrP+il1LBTLwByF0Wr9OqE8TBoMpaVzZpvkYZZwPWWMypenW3q1RGVSRZP 3JWwh1NVcUXQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 May 2020 15:46:22 -0700 IronPort-SDR: DI0EcICjVwKpoK5MkqDRIEfHw6cm/NqwXzr+tY6xSDKEEldYpc/LhJDF2Be5r5mR6rQRvCzj7S 4Bwt3ibh37nA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,419,1583222400"; d="scan'208";a="283216488" Received: from orsmsx107.amr.corp.intel.com ([10.22.240.5]) by orsmga002.jf.intel.com with ESMTP; 21 May 2020 15:46:22 -0700 Received: from orsmsx112.amr.corp.intel.com ([169.254.3.61]) by ORSMSX107.amr.corp.intel.com ([169.254.1.106]) with mapi id 14.03.0439.000; Thu, 21 May 2020 15:46:22 -0700 From: "Kirsher, Jeffrey T" To: Jakub Kicinski CC: "davem@davemloft.net" , "Guedes, Andre" , "netdev@vger.kernel.org" , "nhorman@redhat.com" , "sassmann@redhat.com" , "Brown, Aaron F" Subject: RE: [net-next 03/15] igc: Add support for source address filters in core Thread-Topic: [net-next 03/15] igc: Add support for source address filters in core Thread-Index: AQHWL0FlgPpZUMqG1E6bKdsihznH3aizLyGA///1LsA= Date: Thu, 21 May 2020 22:46:21 +0000 Message-ID: <61CC2BC414934749BD9F5BF3D5D94044986CC07C@ORSMSX112.amr.corp.intel.com> References: <20200521072758.440264-1-jeffrey.t.kirsher@intel.com> <20200521072758.440264-4-jeffrey.t.kirsher@intel.com> <20200521092323.70b8c9b6@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20200521092323.70b8c9b6@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.22.254.139] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > -----Original Message----- > From: Jakub Kicinski > Sent: Thursday, May 21, 2020 09:23 > To: Kirsher, Jeffrey T > Cc: davem@davemloft.net; Guedes, Andre ; > netdev@vger.kernel.org; nhorman@redhat.com; sassmann@redhat.com; > Brown, Aaron F > Subject: Re: [net-next 03/15] igc: Add support for source address filters in core > > On Thu, 21 May 2020 00:27:46 -0700 Jeff Kirsher wrote: > > /** > > * igc_del_mac_filter() - Delete MAC address filter > > * @adapter: Pointer to adapter where the filter should be deleted from > > + * #type: MAC address filter type (source or destination) > > @ here^ otherwise: > > drivers/net/ethernet/intel/igc/igc_main.c:2282: warning: Function parameter or > member 'type' not described in 'igc_del_mac_filter' > [Kirsher, Jeffrey T] I will get that cleaned up. > > * @addr: MAC address > > * > > * Return: 0 in case of success, negative errno code otherwise. > > */ > > -int igc_del_mac_filter(struct igc_adapter *adapter, const u8 *addr) > > +int igc_del_mac_filter(struct igc_adapter *adapter, > > + enum igc_mac_filter_type type, const u8 *addr)